Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_lb_nat_rule with azurestasck PR review requests #1736

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 8, 2018

back-porting changes requested in azure stack review

Also added new All options to the protocol property

@katbyte katbyte added this to the 1.13.0 milestone Aug 8, 2018
@katbyte katbyte requested a review from tombuildsstuff August 8, 2018 00:32
@katbyte katbyte changed the title Updated lb nat rule with azurestasck review findings Update azurerm_lb_nat_rule with azurestasck PR review requests Aug 8, 2018
@katbyte katbyte force-pushed the lb_nat_rule-updates branch from 181a2e6 to c33b1cb Compare August 8, 2018 00:39
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit b70114e into master Aug 8, 2018
katbyte added a commit that referenced this pull request Aug 8, 2018
@katbyte katbyte deleted the lb_nat_rule-updates branch August 9, 2018 19:21
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants