Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/function_app: Add support for outputting site_credentials #1567

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 13, 2018

Fixes: #1328

Modelled on that of app_service

▶ acctests azurerm TestAccAzureRMFunctionApp_
=== RUN   TestAccAzureRMFunctionApp_importBasic
--- PASS: TestAccAzureRMFunctionApp_importBasic (121.08s)
=== RUN   TestAccAzureRMFunctionApp_importTags
--- PASS: TestAccAzureRMFunctionApp_importTags (118.88s)
=== RUN   TestAccAzureRMFunctionApp_importAppSettings
--- PASS: TestAccAzureRMFunctionApp_importAppSettings (140.97s)
=== RUN   TestAccAzureRMFunctionApp_basic
--- PASS: TestAccAzureRMFunctionApp_basic (149.64s)
=== RUN   TestAccAzureRMFunctionApp_tags
--- PASS: TestAccAzureRMFunctionApp_tags (135.59s)
=== RUN   TestAccAzureRMFunctionApp_tagsUpdate
--- PASS: TestAccAzureRMFunctionApp_tagsUpdate (188.66s)
=== RUN   TestAccAzureRMFunctionApp_appSettings
--- PASS: TestAccAzureRMFunctionApp_appSettings (276.09s)
=== RUN   TestAccAzureRMFunctionApp_siteConfig
--- PASS: TestAccAzureRMFunctionApp_siteConfig (129.07s)
=== RUN   TestAccAzureRMFunctionApp_connectionStrings
--- PASS: TestAccAzureRMFunctionApp_connectionStrings (154.03s)
=== RUN   TestAccAzureRMFunctionApp_siteConfigMulti
--- PASS: TestAccAzureRMFunctionApp_siteConfigMulti (321.31s)
=== RUN   TestAccAzureRMFunctionApp_updateVersion
--- PASS: TestAccAzureRMFunctionApp_updateVersion (217.87s)
=== RUN   TestAccAzureRMFunctionApp_3264bit
--- PASS: TestAccAzureRMFunctionApp_3264bit (176.06s)
=== RUN   TestAccAzureRMFunctionApp_httpsOnly
--- PASS: TestAccAzureRMFunctionApp_httpsOnly (149.35s)
=== RUN   TestAccAzureRMFunctionApp_consumptionPlan
--- PASS: TestAccAzureRMFunctionApp_consumptionPlan (146.26s)
=== RUN   TestAccAzureRMFunctionApp_createIdentity
--- PASS: TestAccAzureRMFunctionApp_createIdentity (126.58s)
=== RUN   TestAccAzureRMFunctionApp_updateIdentity
--- PASS: TestAccAzureRMFunctionApp_updateIdentity (129.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	2681.121s

Fixes: 1328

Modelled on that of app_service
@stack72 stack72 changed the title resource/function_app: Add support for outputting site_credentials [WIP] resource/function_app: Add support for outputting site_credentials Jul 13, 2018
@stack72 stack72 changed the title [WIP] resource/function_app: Add support for outputting site_credentials resource/function_app: Add support for outputting site_credentials Jul 13, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍🏼

@tombuildsstuff tombuildsstuff added this to the 1.10.0 milestone Jul 15, 2018
@tombuildsstuff tombuildsstuff merged commit d5bd68e into hashicorp:master Jul 15, 2018
tombuildsstuff added a commit that referenced this pull request Jul 15, 2018
@tombuildsstuff
Copy link
Contributor

hi @stack72

Just to let you know that is now available in [v1.10 of the AzureRM Provider(https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.10.0/CHANGELOG.md#1100-july-21-2018) - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

@arichiardi
Copy link
Contributor

Thanks a lot!

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants