Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDN: support for Standard_Microsoft / China CDN #1465

Merged
merged 2 commits into from
Jul 2, 2018
Merged

CDN: support for Standard_Microsoft / China CDN #1465

merged 2 commits into from
Jul 2, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Closing #1415 in favour of this - unfortunately there's no Constant for Microsoft available at the moment since it's in Preview

$ acctests azurerm TestAccAzureRMCdnProfile_standardMicrosoft
=== RUN   TestAccAzureRMCdnProfile_standardMicrosoft
--- PASS: TestAccAzureRMCdnProfile_standardMicrosoft (189.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	189.377s

@tombuildsstuff tombuildsstuff added this to the 1.9.0 milestone Jun 29, 2018
@tombuildsstuff tombuildsstuff mentioned this pull request Jun 29, 2018
Closed
@tombuildsstuff tombuildsstuff requested a review from a team June 29, 2018 09:43
bflad
bflad approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-07-02 at 15 41 28

@tombuildsstuff tombuildsstuff merged commit 715d939 into master Jul 2, 2018
@tombuildsstuff tombuildsstuff deleted the cdn-ms-china branch July 2, 2018 13:42
tombuildsstuff added a commit that referenced this pull request Jul 2, 2018
@tombuildsstuff
Updating to include #1465
0bf7cbf
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement service/cdn
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @bflad