Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Identity in azurerm_function_app #1369

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Jun 8, 2018

Add identity field into azurerm_function_app similar to the one in azurerm_app_service and azurerm_virtual_machine.

This PR also fixes #1327 .

@JunyiYi JunyiYi self-assigned this Jun 8, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JunyiYi,

Thanks for adding this, LGTM 👍

@katbyte katbyte merged commit d7bc9d0 into master Jun 8, 2018
@katbyte
Copy link
Collaborator

katbyte commented Jun 8, 2018

tests pass:
screen shot 2018-06-08 at 14 06 06

@katbyte katbyte added this to the 1.7.0 milestone Jun 8, 2018
katbyte added a commit that referenced this pull request Jun 8, 2018
@tombuildsstuff tombuildsstuff deleted the identity_in_function_app branch June 18, 2018 11:30
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add MSI support to Function App
2 participants