Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_data_factory_pipeline" - supports "concurrency", "elapsed_time_metric_duration" and "run_dimension" #12685

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jul 22, 2021

fix #11506

"run_dimension" is a key value pair, but the value could be a string or an expression type, so made it TypeList. It's used by ChainingTrigger.

ChainingTrigger allows the referenced pipeline to depend on other pipeline runs based on runDimension Name/Value pairs. Upstream pipelines should declare the same runDimension Name and their runs should have the values for those runDimensions. The referenced pipeline run would be triggered if the values for the runDimension match for all upstream pipeline runs.

image

@@ -72,6 +72,10 @@ The following arguments are supported:

* `annotations` - (Optional) List of tags that can be used for describing the Data Factory Pipeline.

* `concurrency` - (Optional) The max number of concurrent runs for the Data Factory Pipeline. Must be between `1` and `50`.

* `elapsed_time_metric_duration` - (Optional) The TimeSpan value after which an Azure Monitoring Metric is fired.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property doesn't match the description

Suggested change
* `elapsed_time_metric_duration` - (Optional) The TimeSpan value after which an Azure Monitoring Metric is fired.
* `moniter_metrics_after_duration` - (Optional) The TimeSpan value after which an Azure Monitoring Metric is fired.

Comment on lines 93 to 96
* `name` - The name of run_dimension.

* `value` - The value of run_dimension.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we not have a _ in the sentance?

Suggested change
* `name` - The name of run_dimension.
* `value` - The value of run_dimension.
* `name` - The name of the run dimension.
* `value` - The value of the run dimension.


* `value` - The value of run_dimension.

* `dynamic_value_enabled` - is dynamic expression enabled for value?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a dynamic value?

@@ -80,6 +84,20 @@ The following arguments are supported:

* `activities_json` - (Optional) A JSON object that contains the activities that will be associated with the Data Factory Pipeline.

* `run_dimension` - (Optional) One or more `run_dimension` blocks as defined below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a run dimension?

@github-actions github-actions bot added size/S and removed size/L labels Jul 27, 2021
@ms-henglu
Copy link
Contributor

Hi @katbyte , I contacted with service team and removed runDimension property. Could you please take another look? Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 🚀

@katbyte katbyte merged commit ff44eff into hashicorp:master Jul 28, 2021
katbyte added a commit that referenced this pull request Jul 28, 2021
@github-actions
Copy link

This functionality has been released in v2.70.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for concurrency property in azurerm_data_factory_pipeline
3 participants