Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_api_management_redis_cache #12174

Merged
merged 17 commits into from
Jun 17, 2021

Conversation

yupwei68
Copy link
Contributor

Fix #4765

--- PASS: TestAccApiManagementCache_basic (1980.64s)
--- PASS: TestAccApiManagementCache_requiresImport (2013.39s)
--- PASS: TestAccApiManagementCache_complete (1991.81s)
--- PASS: TestAccApiManagementCache_update (2277.54s)

@ghost ghost added the size/XL label Jun 11, 2021
yupwei68 added 2 commits June 11, 2021 15:16
yupwei68 added 2 commits June 15, 2021 10:16
@yupwei68 yupwei68 changed the title New resource azurerm_api_management_cache New resource azurerm_api_management_redis_cache Jun 15, 2021
@yupwei68
Copy link
Contributor Author

Thanks kt, Please continue reviewing.

@yupwei68 yupwei68 requested a review from katbyte June 15, 2021 04:58
@katbyte
Copy link
Collaborator

katbyte commented Jun 16, 2021

thanks, i do want to know why we have a cache_location property - how is this different from the redis location and cannot we not just query the redis cache to get the location from it?

@yupwei68
Copy link
Contributor Author

Hi kt, I think in that way, we could not set a cache with useFromLocation "default". I think the "default" cache is for apim service in non-specified location.

Here is from MS document

The Use from setting specifies an Azure region or a self-hosted gateway location that will use the configured cache. The caches configured as Default will be overridden by caches with a specific matching region or location value.

For example, if API Management is hosted in the East US, Southeast Asia and West Europe regions and there are two caches configured, one for Default and one for Southeast Asia, API Management in Southeast Asia will use its own cache, while the other two regions will use the Default cache entry.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 1ff91fe into hashicorp:master Jun 17, 2021
katbyte added a commit that referenced this pull request Jun 17, 2021
@github-actions
Copy link

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External cache property missing for azurerm_api_management
2 participants