Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for client_certificate_enabled, gateway_disabled, min_api_version and zones in azurerm_api_management #12125

Merged
merged 12 commits into from
Jun 15, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jun 9, 2021

@ghost ghost added the size/XL label Jun 9, 2021
@katbyte
Copy link
Collaborator

katbyte commented Jun 10, 2021

Could we fix the tests:
image

@yupwei68
Copy link
Contributor Author

Hi kt, the acctests are fixed in #12173

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 🍰

@katbyte katbyte added this to the v2.64.0 milestone Jun 15, 2021
@katbyte katbyte merged commit 46ffd6a into hashicorp:master Jun 15, 2021
katbyte added a commit that referenced this pull request Jun 15, 2021
@github-actions
Copy link

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@walima0103
Copy link

walima0103 commented Jun 23, 2021

Hi,

I'm getting this error using the provider v2.64.0:

image

trying to deploy an Internal API Management in Zones:

resource "azurerm_api_management" "wcdtapimtflabapim" {
  name                = "wcdtapimtflabapim"
  location            = azurerm_resource_group.wcdtapimtflabrg.location
  resource_group_name = azurerm_resource_group.wcdtapimtflabrg.name

  zones = [ "1", "2", "3" ]

  sku_name = "Premium_3"

  virtual_network_type = "Internal"

  virtual_network_configuration {
    subnet_id = azurerm_subnet.wcdtapimtflabvnetAPIMSubnet.id
  }

  identity {
    type = "SystemAssigned"
  }

  sign_up {
    enabled = true
    terms_of_service {
      consent_required = false
      enabled          = false
      text             = "The Terms of Service which users are required to agree to in order to sign up"
    }
  }

  publisher_name  = "wcdtapimtflab"
  publisher_email = "[email protected]"

}

Apparently, the parameter "properties.publicIpAddressId" (https://docs.microsoft.com/en-us/rest/api/apimanagement/2021-01-01-preview/api-management-service/create-or-update) is not available in terraform provider.

image

Would it be that?

@yupwei68
Copy link
Contributor Author

Hi @walima0103 Thanks for your comment.

"publicIpAddressId" is a feature currently in preview. I'll get it implemented once it's GA.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management: Add missing setting "minApiVersion"
3 participants