-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_registry
: support for versionless encryption keys for ACR
#11856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tj-corrigan! This fix looks great but I do want to ask for two tests here. One for checking that a versionless key works and another to confirm that we can update encryption
@mbfrahry I went ahead and added a test that creates an encrypted ACR with a specific version and then updates it to use the versionless key. Tests works fine on my machine but it is failing to properly cleanup since the keyvault is required to have purge_protection turned on:
It looks like the tests for DiskEncryptionSet have the same issue but I'm not sure how the CI/CD tools handle that situation. |
Not a problem! That'll work for us! Thanks for taking the time to get that test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
azurerm_container_registry
: support for versionless encryption keys for ACR
This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.62.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #11774
This allows for the use of versionless keys in ACR. I also included a small fix that allows for the upgrading of encryption keys.