Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_spatial_anchors_account - support for account_domain and account_id #11824

Merged
merged 6 commits into from
May 24, 2021
Merged

azurerm_spatial_anchors_account - support for account_domain and account_id #11824

merged 6 commits into from
May 24, 2021

Conversation

favoretti
Copy link
Collaborator

  • deps: upgrade mixedreality to 2021-01-01
  • New data source: azurerm_spatial_anchors_account
  • Add account_id and account_domain properties to
    azurerm_spatial_anchors_account resource
$ TF_ACC=1 go test -v ./azurerm/internal/services/mixedreality -timeout=1000m
2021/05/22 11:25:31 [DEBUG] not using binary driver name, it's no longer needed
2021/05/22 11:25:31 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccSpatialAnchorsAccountDataSource_basic
=== PAUSE TestAccSpatialAnchorsAccountDataSource_basic
=== RUN   TestAccSpatialAnchorsAccount_basic
=== PAUSE TestAccSpatialAnchorsAccount_basic
=== RUN   TestAccSpatialAnchorsAccount_complete
=== PAUSE TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccountDataSource_basic
=== CONT  TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccount_basic
--- PASS: TestAccSpatialAnchorsAccountDataSource_basic (105.96s)
--- PASS: TestAccSpatialAnchorsAccount_complete (111.01s)
--- PASS: TestAccSpatialAnchorsAccount_basic (111.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mixedreality	113.243s

Fixes #11799

@favoretti
Mixed reality updates
f6bcf01 
* deps: upgrade `mixedreality` to `2021-01-01`
* New data source: `azurerm_spatial_anchors_account`
* Add `account_id` and `account_domain` properties to
  `azurerm_spatial_anchors_account` resource

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/mixedreality -timeout=1000m
2021/05/22 11:25:31 [DEBUG] not using binary driver name, it's no longer needed
2021/05/22 11:25:31 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccSpatialAnchorsAccountDataSource_basic
=== PAUSE TestAccSpatialAnchorsAccountDataSource_basic
=== RUN   TestAccSpatialAnchorsAccount_basic
=== PAUSE TestAccSpatialAnchorsAccount_basic
=== RUN   TestAccSpatialAnchorsAccount_complete
=== PAUSE TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccountDataSource_basic
=== CONT  TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccount_basic
--- PASS: TestAccSpatialAnchorsAccountDataSource_basic (105.96s)
--- PASS: TestAccSpatialAnchorsAccount_complete (111.01s)
--- PASS: TestAccSpatialAnchorsAccount_basic (111.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mixedreality	113.243s
```

Fixes #11799
@favoretti
Copy link
Collaborator Author

image

magodo
magodo requested changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

website/docs/d/spatial_anchors_account.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spatial_anchors_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/spatial_anchors_account.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/mixedreality/spatial_anchors_account_data_source_test.go Show resolved Hide resolved
azurerm/internal/services/mixedreality/spatial_anchors_account_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mixedreality/spatial_anchors_account_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mixedreality/spatial_anchors_account_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/mixedreality/spatial_anchors_account_data_source.go Outdated Show resolved Hide resolved
@favoretti
Copy link
Collaborator Author 

$ TF_ACC=1 go test -v ./azurerm/internal/services/mixedreality -timeout=1000m
2021/05/24 09:36:19 [DEBUG] not using binary driver name, it's no longer needed
2021/05/24 09:36:19 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccSpatialAnchorsAccountDataSource_basic
=== PAUSE TestAccSpatialAnchorsAccountDataSource_basic
=== RUN   TestAccSpatialAnchorsAccount_basic
=== PAUSE TestAccSpatialAnchorsAccount_basic
=== RUN   TestAccSpatialAnchorsAccount_complete
=== PAUSE TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccountDataSource_basic
=== CONT  TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccount_basic
--- PASS: TestAccSpatialAnchorsAccountDataSource_basic (104.19s)
--- PASS: TestAccSpatialAnchorsAccount_basic (111.64s)
--- PASS: TestAccSpatialAnchorsAccount_complete (113.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mixedreality	114.963s

@favoretti favoretti requested a review from magodo May 24, 2021 07:40
@favoretti
Copy link
Collaborator Author 

$ TF_ACC=1 go test -v ./azurerm/internal/services/mixedreality -timeout=1000m
2021/05/24 11:21:59 [DEBUG] not using binary driver name, it's no longer needed
2021/05/24 11:22:00 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccSpatialAnchorsAccountDataSource_basic
=== PAUSE TestAccSpatialAnchorsAccountDataSource_basic
=== RUN   TestAccSpatialAnchorsAccount_basic
=== PAUSE TestAccSpatialAnchorsAccount_basic
=== RUN   TestAccSpatialAnchorsAccount_complete
=== PAUSE TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccountDataSource_basic
=== CONT  TestAccSpatialAnchorsAccount_complete
=== CONT  TestAccSpatialAnchorsAccount_basic
--- PASS: TestAccSpatialAnchorsAccountDataSource_basic (104.94s)
--- PASS: TestAccSpatialAnchorsAccount_basic (111.45s)
--- PASS: TestAccSpatialAnchorsAccount_complete (111.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/mixedreality	113.732s

@favoretti
Copy link
Collaborator Author

image

@magodo magodo changed the title Mixed reality updates azurerm_spatial_anchors_account - support for account_domain and account_id May 24, 2021
@magodo magodo merged commit a4e7753 into hashicorp:master May 24, 2021
@magodo
Copy link
Collaborator

magodo commented May 24, 2021

@favoretti LGTM 👍

magodo added a commit that referenced this pull request May 24, 2021
@magodo
Update CHANGELOG.md to include #11824
bb3af77
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magodo magodo Awaiting requested review from magodo

Assignees
No one assigned
Labels
dependencies documentation new-data-source service/mixed-reality size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return account_domain account_id from spatial_anchors_account properties + Add Data Source
2 participants
@favoretti @magodo