Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_linux|windows_virtual_machine - enable update for proximity_placement_group_id #11790

Merged

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented May 20, 2021

Fixes #11515

@katbyte
Copy link
Collaborator

katbyte commented Jun 3, 2021

could we fix this build up?

	[Step 4/5] # github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute_test [github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute.test]
[16:27:32]	[Step 4/5] ./linux_virtual_machine_resource_scaling_test.go:112:28: undefined: resource
[16:27:32]	[Step 4/5] ./linux_virtual_machine_resource_scaling_test.go:134:28: undefined: resource
[16:27:32]	[Step 4/5] ./windows_virtual_machine_resource_scaling_test.go:128:28: undefined: resource
[16:27:32]	[Step 4/5] ./windows_virtual_machine_resource_scaling_test.go:154:28: undefined: resource
[16:28:20]	[Step 4/5] Process exited with code 2

@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte sorry for the delay of response. I have fixed the compile errors in the test cases. Please have a look again

@katbyte
Copy link
Collaborator

katbyte commented Jun 22, 2021

thanks, running the tests for this there are a lot of failures.. could we possibly fix some of them up so its more apparent if this is causing any issues?

image

thanks

@ArcturusZhang
Copy link
Contributor Author

The failed test cases does not have assigned the ppg attribute, and the only thing changed in this PR is the update function for ppg, therefore I assume those should be irrelevant.

@ArcturusZhang
Copy link
Contributor Author

Just checked TC, those test cases have been failing on master branch

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes, i'd still like those tests to get fixed up so future PRs are more easily checked - changes LGTM ✅

@katbyte katbyte added this to the v2.65.0 milestone Jun 24, 2021
@katbyte katbyte merged commit aed1136 into hashicorp:master Jun 24, 2021
katbyte added a commit that referenced this pull request Jun 24, 2021
@ArcturusZhang ArcturusZhang deleted the patch-proximity-placement-group-id branch June 25, 2021 01:52
@github-actions
Copy link

This functionality has been released in v2.65.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_*_virtual_machine: Changing proximity_placement_group_id should not force new resource
2 participants