Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UserAssignedIdentity in azurerm_storage_account #11752

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

yupwei68
Copy link
Contributor

Fix #11751

--- PASS: TestAccStorageAccount_systemAssignedIdentity (160.00s)
--- PASS: TestAccStorageAccount_userAssignedIdentity (171.82s)
--- PASS: TestAccStorageAccount_systemAssignedUserAssignedIdentity (171.53s)
--- PASS: TestAccStorageAccount_updateResourceByEnablingIdentity (421.15s)

@yupwei68 yupwei68 requested a review from katbyte June 3, 2021 02:38
@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 3, 2021

Thanks kt for your comments.
I've updated according to your comment. But on fact, I still think making identity Computed prevents users from disabling identity.
All tests have passed.
Please continue reviewing.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte modified the milestones: v2.62.0, v2.63.0 Jun 3, 2021
@katbyte katbyte merged commit 929f2f6 into hashicorp:master Jun 4, 2021
katbyte added a commit that referenced this pull request Jun 4, 2021
@yupwei68 yupwei68 deleted the wyp-storage-acc4 branch June 7, 2021 06:43
@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for UserAssignedIdentity in azurerm_storage_account
3 participants