Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_storage_object_replication_policy #11744

Merged
merged 11 commits into from
Jun 3, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 17, 2021

Fix: #8647

--- PASS: TestAccStorageObjectReplicationPolicy_basic (205.37s)
--- PASS: TestAccStorageObjectReplicationPolicy_requiresImport (222.11s)
--- PASS: TestAccStorageObjectReplicationPolicy_complete (200.17s)
-- PASS: TestAccStorageObjectReplicationPolicy_update (562.02s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - overall looks good and i've left some comments inline

@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 2, 2021

Thanks kt for your comments.

Tests have passed:
--- PASS: TestAccStorageObjectReplication_basic (206.76s)
--- PASS: TestAccStorageObjectReplication_requiresImport (225.44s)
--- PASS: TestAccStorageObjectReplication_complete (225.87s)
--- PASS: TestAccStorageObjectReplication_update (611.86s)

Please continue reviewing.

@katbyte katbyte added this to the v2.62.0 milestone Jun 3, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit e6443f0 into hashicorp:master Jun 3, 2021
katbyte added a commit that referenced this pull request Jun 3, 2021
@yupwei68 yupwei68 deleted the wyp-storage-orp2 branch June 4, 2021 01:40
@ghost
Copy link

ghost commented Jun 4, 2021

This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.62.0"
}
# ... other configuration ...

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for storage account object replication
2 participants