-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_storage_object_replication_policy
#11744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - overall looks good and i've left some comments inline
azurerm/internal/services/storage/storage_object_replication_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_object_replication_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_object_replication_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_object_replication_policy_resource.go
Outdated
Show resolved
Hide resolved
Thanks kt for your comments. Tests have passed: Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - LGTM 👍
This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.62.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix: #8647
--- PASS: TestAccStorageObjectReplicationPolicy_basic (205.37s)
--- PASS: TestAccStorageObjectReplicationPolicy_requiresImport (222.11s)
--- PASS: TestAccStorageObjectReplicationPolicy_complete (200.17s)
-- PASS: TestAccStorageObjectReplicationPolicy_update (562.02s)