Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection - update shared_key #11742

Merged
merged 1 commit into from
May 17, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 17, 2021

The PUT operation on the vnet gw connection will not update the shared_key, users have to use a dedicated sharedKey endpoint to do this. This issue causes the acctest for TestAccVirtualNetworkGatewayConnection_updatingSharedKey failed.

Fixes: #11673

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, this LGTM and the tests are passing (one unrelated failure):

Screenshot 2021-05-17 at 13 14 58

@manicminer manicminer added this to the v2.60.0 milestone May 17, 2021
@manicminer manicminer merged commit 839cb60 into hashicorp:master May 17, 2021
manicminer added a commit that referenced this pull request May 17, 2021
@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared_key is not updated for existing azurerm_virtual_network_gateway_connection
2 participants