Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_healthcare_service: Add public_network_access_enabled argument #11736

Merged
merged 4 commits into from
May 18, 2021
Merged

azurerm_healthcare_service: Add public_network_access_enabled argument #11736

merged 4 commits into from
May 18, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented May 16, 2021

$ TF_ACC=1 go test -v ./azurerm/internal/services/healthcare -timeout=1000m -run 'TestAccHealthCareService_publicNetworkAccessDisabled'
2021/05/16 10:09:20 [DEBUG] not using binary driver name, it's no longer needed
2021/05/16 10:09:20 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHealthCareService_publicNetworkAccessDisabled
=== PAUSE TestAccHealthCareService_publicNetworkAccessDisabled
=== CONT  TestAccHealthCareService_publicNetworkAccessDisabled
--- PASS: TestAccHealthCareService_publicNetworkAccessDisabled (1139.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/healthcare	1140.778s

image

Fixes #11730

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - just one small comment about the schema, we can make it a boolean and translate it to the correct flag in the provider

@ghost ghost added size/L and removed size/M labels May 17, 2021
@favoretti favoretti requested a review from katbyte May 17, 2021 06:53
@ghost ghost added size/M and removed size/L labels May 17, 2021
@favoretti
Copy link
Collaborator Author

favoretti commented May 17, 2021

$ TF_ACC=1 go test -v ./azurerm/internal/services/healthcare -timeout=1000m -run 'TestAccHealthCareService_basic'
2021/05/17 10:47:42 [DEBUG] not using binary driver name, it's no longer needed
2021/05/17 10:47:42 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHealthCareService_basic
=== PAUSE TestAccHealthCareService_basic
=== CONT  TestAccHealthCareService_basic
--- PASS: TestAccHealthCareService_basic (917.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/healthcare	918.866s
$ TF_ACC=1 go test -v ./azurerm/internal/services/healthcare -timeout=1000m -run 'TestAccHealthCareService_publicNetworkAccessDisabled'
2021/05/17 10:22:32 [DEBUG] not using binary driver name, it's no longer needed
2021/05/17 10:22:32 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHealthCareService_publicNetworkAccessDisabled
=== PAUSE TestAccHealthCareService_publicNetworkAccessDisabled
=== CONT  TestAccHealthCareService_publicNetworkAccessDisabled
--- PASS: TestAccHealthCareService_publicNetworkAccessDisabled (1197.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/healthcare	1198.479s

image

@favoretti favoretti changed the title azurerm_healthcare_service: Add public_network_access argument azurerm_healthcare_service: Add public_network_access_enabled argument May 17, 2021
@katbyte katbyte added this to the v2.60.0 milestone May 18, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte merged commit c56d478 into hashicorp:master May 18, 2021
katbyte added a commit that referenced this pull request May 18, 2021
@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti added a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "public network access' setting to azurerm_healthcare_service
2 participants