Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - empty allowed_headers and exposed_headers #11692

Merged
merged 1 commit into from
May 13, 2021

Conversation

alvintang
Copy link
Contributor

No description provided.

@ghost ghost added the size/S label May 13, 2021
@katbyte katbyte changed the title fix for #10936 azurerm_storage_account - empty allowed_headers and exposed_headers May 13, 2021
@katbyte katbyte added this to the v2.59.0 milestone May 13, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alvintang - LGTM 👍

@katbyte katbyte merged commit 0af7724 into hashicorp:master May 13, 2021
katbyte added a commit that referenced this pull request May 13, 2021
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

@CraigStuntzWillowTree
Copy link

So with this change, an empty list of headers is not accepted, but a list containing the empty string is accepted. We can live with this, but it seems less than ideal?

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants