Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_netapp_volume - support for the security_style property - Fixes #11370 #11684

Merged
merged 10 commits into from
May 20, 2021
Merged

azurerm_netapp_volume - support for the security_style property - Fixes #11370 #11684

merged 10 commits into from
May 20, 2021

Conversation

paulomarquesc
Copy link
Contributor

This PR implements security_style volume property. It Fixes #11370.

@katbyte katbyte added this to the v2.59.0 milestone May 13, 2021
katbyte
katbyte requested changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulomarquesc - just a couple small comments

azurerm/internal/services/netapp/netapp_volume_resource.go Outdated
Comment on lines 127 to 128
"Unix",
"Ntfs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use the SDK build in constants here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to leave as is since the backend is changing the values to pascal case which differs from the sdk.

website/docs/r/netapp_volume.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte modified the milestones: v2.59.0, v2.60.0 May 14, 2021
@paulomarquesc
Changing securoty_style to be in-sync with backend default of Ntfs in…
d97cb40 
… a dual protocol scenario when not provided.
@katbyte katbyte self-assigned this May 17, 2021
katbyte
katbyte approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulomarquesc - LGTM 👍

@katbyte katbyte changed the title Implements security_style on ANF volume property - Fixes #11370 azurerm_netapp_volume - support for the security_style property - Fixes #11370 May 20, 2021
@katbyte katbyte merged commit a759647 into hashicorp:master May 20, 2021
katbyte added a commit that referenced this pull request May 20, 2021
@katbyte
CHANGELOG.md for #11684
3ce1187
@paulomarquesc paulomarquesc deleted the pmarques/fixes_11370 branch May 20, 2021 02:21
@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@paulomarquesc @favoretti
azurerm_netapp_volume - support for the security_style property - F…
a07e7fe 
…ixes hashicorp#11370 (hashicorp#11684)

This PR implements security_style volume property. It Fixes hashicorp#11370.
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@katbyte @favoretti
CHANGELOG.md for hashicorp#11684
41eb286
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees

@katbyte katbyte

Labels
documentation enhancement service/netapp size/S
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.

netapp dual protocol volume created with wrong order of protocols and security style
2 participants
@paulomarquesc @katbyte