-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor azurerm_network_watcher_flow_log
and add supports for location
and tags
#11670
Refactor azurerm_network_watcher_flow_log
and add supports for location
and tags
#11670
Conversation
@katbyte Would you please take a look at this PR? Some customers are blocked by this. |
data := acceptance.BuildTestData(t, "azurerm_network_watcher", "test") | ||
r := NetworkWatcherResource{} | ||
|
||
data.ResourceTest(t, r, []acceptance.TestStep{ | ||
data.ResourceSequentialTest(t, r, []acceptance.TestStep{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this working correctly? all the tests are failing in teamcity now, worse then before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - LGTM 👍
This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.63.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This refactors the
azurerm_network_watcher_flow_log
to using its own separate endpoint - rather than using theconfigureFlowLog
endpoint of the Network Watcher (more details here)This PR is implemented in a way to avoid breaking changes on the existing instances and ensure backward compatiblility (locally tested).
Besides, I've modified the test cases to make them sequential - the prior implementation actually are still running in parallel at the end.
Fixes: #11587
Test Result