-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update network sdk to 2020-11-01 #11627
update network sdk to 2020-11-01 #11627
Conversation
aa9fd1f
to
0929348
Compare
0929348
to
69d79a8
Compare
Hi @ms-henglu - I hope you don't mind, but I've taken a look into this and saw a way to avoid the breaking behavioural change for users and allow them to take advantage of "no zone", so I've updated your PR. Assuming it passes regression tests I'll get another one of the team to review my changes and we should be able to get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jadckofallops - LGTM!
This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.63.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #11707
When update network sdk to 2020-11-01, there's a breaking change : https://azure.microsoft.com/en-us/updates/zone-behavior-change/
To address this breaking change, I use provider API to get available zone list for a location, and use it as default value to keep the behavior unchanged, if user wants to use non-zonal resource, user can set zones = ["no_zone"]