-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_data_factory_dataset_snowflake
#11116
New Resource: azurerm_data_factory_dataset_snowflake
#11116
Conversation
azurerm_data_factory_dataset_snowflake
#11051azurerm_data_factory_dataset_snowflake
52ce342
to
d09e732
Compare
…wflake' into azurerm_data_factory_dataset_snowflake # Conflicts: # website/docs/r/data_factory_dataset_snowflake.html.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @orestiskats19! This PR is looking really good. I have a couple of asks from you and then we can merge it in!
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/datafactory/data_factory_dataset_snowflake_resource_test.go
Outdated
Show resolved
Hide resolved
Hey @mbfrahry, thanks for reviewing my PR. I have made the changes that you suggested, let me know what you think 😃 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for addressing the review @orestiskats19! It should go out in 2.57.0 of the provider |
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
New Resource for Snowflake table in data factory service:
azurerm_data_factory_dataset_snowflake
.Resolves issue #11051 .