Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_data_factory_dataset_snowflake #11116

Merged

Conversation

orestiskats19
Copy link
Contributor

@orestiskats19 orestiskats19 commented Mar 25, 2021

New Resource for Snowflake table in data factory service: azurerm_data_factory_dataset_snowflake.
Resolves issue #11051 .

@orestiskats19 orestiskats19 changed the title New Resource: azurerm_data_factory_dataset_snowflake #11051 New Resource: azurerm_data_factory_dataset_snowflake Mar 25, 2021
@orestiskats19 orestiskats19 force-pushed the azurerm_data_factory_dataset_snowflake branch from 52ce342 to d09e732 Compare March 26, 2021 17:08
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @orestiskats19! This PR is looking really good. I have a couple of asks from you and then we can merge it in!

@orestiskats19
Copy link
Contributor Author

Hey @mbfrahry, thanks for reviewing my PR. I have made the changes that you suggested, let me know what you think 😃 .

@ghost ghost removed the waiting-response label Apr 18, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.57.0 milestone Apr 19, 2021
@mbfrahry mbfrahry merged commit 61bf9a9 into hashicorp:master Apr 19, 2021
mbfrahry added a commit that referenced this pull request Apr 19, 2021
@mbfrahry
Copy link
Member

Thanks for addressing the review @orestiskats19! It should go out in 2.57.0 of the provider

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants