-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: azurerm_media_asset_filter
#11110
new resource: azurerm_media_asset_filter
#11110
Conversation
…form-provider-azurerm into azurerm_media_asset_filter
…form-provider-azurerm into azurerm_media_asset_filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - overall this looks good but i have some questions about the schema and docs, i think we can improve the UX and be a little more detailed.
azurerm_media_asset_filter
Thanks @katbyte I applied your suggestions, so you can take a look again |
…rm-provider-azurerm into azurerm_media_asset_filter
…rm-provider-azurerm into azurerm_media_asset_filter
Hi @katbyte I applied your recommendations to improve UX on presentation_time_range. The only thing is for this version only unit_timescale_in_miliseconds will be supported. unit_timescale_in_microseconds could be a enhancement in a future version, but I tested and I think miliseconds should be enough for most of cases. I tried to implement microseconds but is a little tricky to identify on read method if the timeScale was configured as microseconds or miliseconds because in the API is a unique property and is finally a number. One option could be to read last saved state. Let me know any comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @caius - LGTM 👍
Hi This PR resolves hashicorp#11054 Checked: Update Documentation Add new Acceptance Test and verified that the tests pass successfully Check linting
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Hi
This PR resolves #11054
Checked:
Update Documentation
Add new Acceptance Test and verified that the tests pass successfully
Check linting