Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_media_asset_filter #11110

Merged
merged 13 commits into from
Apr 29, 2021
Merged

new resource: azurerm_media_asset_filter #11110

merged 13 commits into from
Apr 29, 2021

Conversation

jcanizalez
Copy link
Contributor

Hi
This PR resolves #11054

Checked:

Update Documentation
Add new Acceptance Test and verified that the tests pass successfully
Check linting

@ghost ghost added the dependencies label Mar 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - overall this looks good but i have some questions about the schema and docs, i think we can improve the UX and be a little more detailed.

@jcanizalez jcanizalez changed the title new resource: azurerm_media_asset_filter new resource: azurerm_media_asset_filter Apr 8, 2021
@jcanizalez
Copy link
Contributor Author

Thanks @katbyte I applied your suggestions, so you can take a look again

@jcanizalez jcanizalez requested a review from katbyte April 8, 2021 19:32
@ghost ghost removed the waiting-response label Apr 8, 2021
@katbyte katbyte added this to the v2.56.0 milestone Apr 13, 2021
…rm-provider-azurerm into azurerm_media_asset_filter
@katbyte katbyte modified the milestones: v2.56.0, v2.57.0 Apr 16, 2021
@jcanizalez
Copy link
Contributor Author

Hi @katbyte I applied your recommendations to improve UX on presentation_time_range. The only thing is for this version only unit_timescale_in_miliseconds will be supported. unit_timescale_in_microseconds could be a enhancement in a future version, but I tested and I think miliseconds should be enough for most of cases. I tried to implement microseconds but is a little tricky to identify on read method if the timeScale was configured as microseconds or miliseconds because in the API is a unique property and is finally a number. One option could be to read last saved state. Let me know any comments

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caius - LGTM 👍

@katbyte katbyte merged commit cd74d99 into hashicorp:master Apr 29, 2021
katbyte added a commit that referenced this pull request Apr 29, 2021
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021
Hi
This PR resolves hashicorp#11054

Checked:

Update Documentation
Add new Acceptance Test and verified that the tests pass successfully
Check linting
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021
@jcanizalez jcanizalez deleted the azurerm_media_asset_filter branch April 29, 2021 13:21
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Asset Filter in Media Service Account
3 participants