Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional Access improvements, support for device conditions #673

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Conditional Access improvements, support for device conditions #673

merged 7 commits into from
Nov 25, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Nov 22, 2021 •
edited
Loading

Depends on manicminer/hamilton#125 and requires rebase

Improvements for azuread_conditional_access:

  • use SDK constants for enum validation
  • reflect new API handling of sessionControls property
  • make all enums case insensitive since the API treats them as such
  • support the device_filter block (intentionally within a devices block as there are additional properties to come)

Closes: #669

@manicminer manicminer added this to the v2.11.0 milestone Nov 22, 2021
@manicminer manicminer force-pushed the feature/conditional-access-device-conditions branch from 53aa938 to 9497d4d Compare November 22, 2021 21:59
@manicminer manicminer changed the title Feature/conditional access device conditions Conditional Access improvements, support for device conditions Nov 22, 2021
katbyte
katbyte requested changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - couple comments with my main one being why are we ignoring case? we typically normalize it to the correct value of the API doesn't respect it?

docs/resources/conditional_access_policy.md Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
internal/services/conditionalaccess/conditional_access_policy_resource.go Outdated Show resolved Hide resolved
@manicminer manicminer force-pushed the feature/conditional-access-device-conditions branch from 8516a68 to 19a6285 Compare November 25, 2021 12:54
@manicminer manicminer force-pushed the feature/conditional-access-device-conditions branch from 19a6285 to 1a8aef7 Compare November 25, 2021 13:49
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-11-25 at 14 38 52

@manicminer manicminer requested a review from katbyte November 25, 2021 14:47
@manicminer manicminer force-pushed the feature/conditional-access-device-conditions branch from 1a8aef7 to bd039f5 Compare November 25, 2021 19:54
@manicminer manicminer force-pushed the feature/conditional-access-device-conditions branch from bd039f5 to c37e16e Compare November 25, 2021 19:55
katbyte
katbyte approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - LGTM 🙌

@manicminer manicminer merged commit 8c7e58a into main Nov 25, 2021
@manicminer manicminer deleted the feature/conditional-access-device-conditions branch November 25, 2021 22:37
manicminer added a commit that referenced this pull request Nov 25, 2021
@manicminer
Changelog for #673
914d9d5
@github-actions
Copy link

This functionality has been released in v2.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies enhancement feature/conditional-access size/XL
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Conditional Access - add Device Filter conditions to tf file argument syntax
2 participants
@manicminer @katbyte