Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azuread_groups: support the mail_enabled and security_enabled properties #603

Merged
merged 5 commits into from
Sep 30, 2021

Conversation

manicminer
Copy link
Contributor

Also add an acceptance helper to check values with a custom validation func

Closes: #551

Thanks to @Threpio for initial work in #552

@manicminer manicminer added this to the v2.5.0 milestone Sep 28, 2021
@manicminer manicminer requested a review from a team September 28, 2021 13:36
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-09-28 at 16 38 28

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one docs comment, otherwise LGTM 👍

docs/data-sources/groups.md Outdated Show resolved Hide resolved
Co-authored-by: jackofallops <[email protected]>
@manicminer manicminer merged commit b793fcb into main Sep 30, 2021
@manicminer manicminer deleted the feature/groups-data-source-mail-security-enabled branch September 30, 2021 20:05
manicminer added a commit that referenced this pull request Sep 30, 2021
@github-actions
Copy link

This functionality has been released in v2.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for azuread_groups security_enabled
2 participants