Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_service_principal: support the features block #571

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 13, 2021

This adds a features block to the service principal resource and data source. Service principals are configured by Azure using magic tags. The presence of a tag value enables a particular feature or behaviour, and the absence disables or removes that feature.

These magic tag values are not officially documented and have been deduced via the portal and some community resources (see below).

Because we already allow tags to be set manually, this features block is an alternative to specifying tags. The same can be achieved with either, the latter is just more frustrating to users who don't wish to trawl the web for these magic values.

These are translated into schema properties as follows:

Schema Property Magic Tag Default Value
custom_single_sign_on_app WindowsAzureActiveDirectoryCustomSingleSignOnApplication false
enterprise_application WindowsAzureActiveDirectoryIntegratedApp false
gallery_application WindowsAzureActiveDirectoryGalleryApplicationNonPrimaryV1 false
visible_to_users HideApp true

Sources:

Closes: #354
Related: #7 and #173

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-09-14 at 10 23 46

@manicminer manicminer merged commit e5644fc into main Sep 14, 2021
@manicminer manicminer deleted the feature/service-principal-features branch September 14, 2021 09:24
manicminer added a commit that referenced this pull request Sep 14, 2021
@github-actions
Copy link

This functionality has been released in v2.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_service_principal - Improved UX for tags (was: Missing Visible to Users Interface)
2 participants