Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_group: wait for replication before adding owners/members #290

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

manicminer
Copy link
Contributor

Also tidy up group related error messages

Fixes: #220

@manicminer manicminer added this to the v0.11.0 milestone Jul 1, 2020
@manicminer manicminer requested a review from a team July 1, 2020 00:50
@ghost ghost added the size/S label Jul 1, 2020
@manicminer
Copy link
Contributor Author

Test results:

Screenshot 2020-07-01 02 43 17

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGLTM 👍

@manicminer manicminer merged commit df559ba into master Jul 1, 2020
@manicminer manicminer deleted the group/replication-wait-before-owners branch July 1, 2020 23:00
manicminer added a commit that referenced this pull request Jul 1, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to add azuread_group owners, resource not found
2 participants