azuread_service_principal: export the oauth2_permissions property

[joakimhellum]

Use case is to read permissions from "Microsoft Applications", for example:

data "azuread_service_principal" "main" {
  display_name = "Microsoft Graph"
}

output "oauth2_permissions" {
  value = data.azuread_service_principal.main.oauth2_permissions
}

• Run make testacc TESTARGS='-run=TestAccAzureADServicePrincipalDataSource_byApplicationId'
• Run make testacc TESTARGS='-run=TestAccAzureADServicePrincipal_basic'
• Make adjustments after SDK upgrade

[katbyte]

Hi @joakimhellum-in,

Thank you for the PR, but i'm going to hold off reviewing this until #102 is merged (or you rebase off said PR) as the SDK changes to a largest degree.

[katbyte]

I've left some comments inline here @joakimhellum-in, the main concern is the duplicated schema and code. If we could share all that in a graph.SchemaOauth2Permissions function & graph.[Expand|Flatten]Oauth2Permissions that would be great.

[joakimhellum]

@katbyte Thanks for your patience. Have made an attempt to address code review comments.

[katbyte]

thanks for the revisions @joakimhellum-in! perfect 👌👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!