Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_vpn_connection: fix possible remote state data inconsistency #11298

Closed
wants to merge 302 commits into from
Closed

aws_vpn_connection: fix possible remote state data inconsistency #11298

wants to merge 302 commits into from

Conversation

n3ph
Copy link
Contributor

@n3ph n3ph commented Dec 14, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11293
Closes #396
Closes #5809
Closes #10584

Release note for CHANGELOG:

aws_vpn_connection: fix possible remote state data inconsistency

Output from acceptance testing:

After substantiation of test case (20b9373):

make testacc TEST=./aws TESTARGS='-run=TestAWSVpnConnection_xmlconfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAWSVpnConnection_xmlconfig -timeout 120m
=== RUN   TestAWSVpnConnection_xmlconfig
--- FAIL: TestAWSVpnConnection_xmlconfig (0.00s)
    resource_aws_vpn_connection_test.go:397: First address from tunnel XML was incorrect.
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	0.019s
FAIL
make: *** [GNUmakefile:24: testacc] Error 1

After fixing the sorting (ac712d1):

 make testacc TEST=./aws TESTARGS='-run=TestAWSVpnConnection_xmlconfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAWSVpnConnection_xmlconfig -timeout 120m
=== RUN   TestAWSVpnConnection_xmlconfig
--- PASS: TestAWSVpnConnection_xmlconfig (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.018s

@n3ph n3ph requested a review from a team December 14, 2019 23:03
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 14, 2019
@n3ph n3ph changed the title Fix vpn order [WIP] aws_vpn_connection: fix possible remote state data inconsistency Dec 14, 2019
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 14, 2019
@n3ph n3ph changed the title [WIP] aws_vpn_connection: fix possible remote state data inconsistency aws_vpn_connection: fix possible remote state data inconsistency Dec 14, 2019
This was referenced Dec 17, 2019
Closed
Closed
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2019
@n3ph
Copy link
Contributor Author

n3ph commented Feb 20, 2020 •
edited
Loading

... forgot --rebase in git pull so needed to rewind and force-push the proper rebased tree.. :-/

@n3ph n3ph requested a review from bflad February 21, 2020 03:56
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/directoryservice service/efs Issues and PRs that pertain to the efs service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/lambda Issues and PRs that pertain to the lambda service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/sts Issues and PRs that pertain to the sts service. service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed size/S Managed by automation to categorize the size of a PR. labels May 30, 2020
@n3ph n3ph closed this May 30, 2020
@n3ph n3ph deleted the fix-vpn-order branch May 30, 2020 12:57
@n3ph
Copy link
Contributor Author

n3ph commented May 30, 2020

Fucked up the rebase - Anyhow - nobody seemed to be interested

@ghost
Copy link

ghost commented Jun 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad Awaiting requested review from bflad

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/lambda Issues and PRs that pertain to the lambda service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/sts Issues and PRs that pertain to the sts service. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone