Acm cert transparency logging

[mattburgess]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #6789

Release note for CHANGELOG:

resource/aws_acm_certificate: Support `options` configuration block `certificate_transparency_logging_preference` argument [GH-6789]

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAcmCertificate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAcmCertificate -timeout 120m
...
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (21.76s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (31.86s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (32.80s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (36.65s)
--- PASS: TestAccAWSAcmCertificate_wildcard (36.98s)
--- PASS: TestAccAWSAcmCertificate_root (37.06s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (38.94s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (34.14s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (36.32s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (36.92s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (48.05s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (56.33s)
--- PASS: TestAccAWSAcmCertificate_tags (97.05s)
...

Note that the other acceptance tests fail, but that looks to be because of the DNS config in my test account

[mattburgess]

@nywilken are you able to review/approve this please (simply based on you having closed #5696 in favour of #6789 which this PR attempts to address).

This is required in order to support private cert requests (see #5550 / #6666 / #9288) with the appropriate level of security.

[bflad]

Looks good, @mattburgess, thanks 🚀

--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (9.71s)
--- PASS: TestAccAWSAcmCertificate_wildcard (12.76s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (13.31s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (14.67s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (15.26s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (15.30s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (16.45s)
--- PASS: TestAccAWSAcmCertificate_root (16.50s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (17.11s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (17.73s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (17.81s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (21.79s)
--- PASS: TestAccAWSAcmCertificate_san_single (22.78s)
--- PASS: TestAccAWSAcmCertificate_tags (33.14s)

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!