Fix Restriction of SQL Server RDS Indentifier Length

[thefringeninja]

sql server rds no longer has this restriction

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9037

Release note for CHANGELOG:

Removes identifier length restriction of aws_db_instance when using sql server

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bflad]

Thank you for this update, @thefringeninja 🚀 Verified that a SQL Server provisions just fine with a lengthy identifier_prefix specified and this code change.

[ghost]

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!