Retries for appautoscaling

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_appautoscaling_policy: Retries after timeouts in creating and reading policies
* resource/aws_appautoscaling_scheduled_action: Retry after timeout putting scheduled actions

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSAppautoscalingScheduledAction"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAppautoscalingScheduledAction -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAppautoscalingScheduledAction_dynamo
=== PAUSE TestAccAWSAppautoscalingScheduledAction_dynamo
=== RUN   TestAccAWSAppautoscalingScheduledAction_ECS
=== PAUSE TestAccAWSAppautoscalingScheduledAction_ECS
=== RUN   TestAccAWSAppautoscalingScheduledAction_EMR
=== PAUSE TestAccAWSAppautoscalingScheduledAction_EMR
=== RUN   TestAccAWSAppautoscalingScheduledAction_SpotFleet
=== PAUSE TestAccAWSAppautoscalingScheduledAction_SpotFleet
=== CONT  TestAccAWSAppautoscalingScheduledAction_dynamo
=== CONT  TestAccAWSAppautoscalingScheduledAction_SpotFleet
=== CONT  TestAccAWSAppautoscalingScheduledAction_ECS
=== CONT  TestAccAWSAppautoscalingScheduledAction_EMR
--- PASS: TestAccAWSAppautoscalingScheduledAction_ECS (77.55s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_SpotFleet (83.48s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_dynamo (137.77s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (459.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       461.753s


make testacc TESTARGS="-run=TestAccAWSAppautoScalingPolicy" ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAppautoScalingPolicy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAppautoScalingPolicy_basic
=== PAUSE TestAccAWSAppautoScalingPolicy_basic
=== RUN   TestAccAWSAppautoScalingPolicy_disappears
=== PAUSE TestAccAWSAppautoScalingPolicy_disappears
=== RUN   TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== PAUSE TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== PAUSE TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== RUN   TestAccAWSAppautoScalingPolicy_dynamoDb
=== PAUSE TestAccAWSAppautoScalingPolicy_dynamoDb
=== RUN   TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== PAUSE TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== RUN   TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== PAUSE TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== RUN   TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== PAUSE TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== CONT  TestAccAWSAppautoScalingPolicy_basic
=== CONT  TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== CONT  TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== CONT  TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== CONT  TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== CONT  TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== CONT  TestAccAWSAppautoScalingPolicy_disappears
=== CONT  TestAccAWSAppautoScalingPolicy_dynamoDb
--- PASS: TestAccAWSAppautoScalingPolicy_basic (85.19s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (86.10s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (90.23s)
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (91.59s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (118.11s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (144.48s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (144.61s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (549.90s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       556.579s

[bflad]

LGTM! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAppautoscalingScheduledAction_dynamo (23.96s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (27.51s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (28.01s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_SpotFleet (56.93s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (59.85s)
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (66.26s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (68.59s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (73.43s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_ECS (76.30s)
--- PASS: TestAccAWSAppautoScalingPolicy_basic (77.52s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (116.53s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (387.59s)

[bflad]

❤️

[bflad]

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!