Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tags for sns topic #8468

Merged
merged 3 commits into from
May 14, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #8460

Changes proposed in this pull request:

  • Support for tags added for sns topic

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSNSTopic_tags'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSSNSTopic_tags -timeout 120m
=== RUN   TestAccAWSSNSTopic_tags
=== PAUSE TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_tags
--- PASS: TestAccAWSSNSTopic_tags (69.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.110s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 14, 2019
@bflad bflad added this to the v2.11.0 milestone May 14, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @sunilkumarmohanty! 🚀

Output from acceptance testing (AWS Standard):

--- PASS: TestAccAWSSNSTopic_namePrefix (13.31s)
--- PASS: TestAccAWSSNSTopic_name (13.43s)
--- PASS: TestAccAWSSNSTopic_basic (13.43s)
--- PASS: TestAccAWSSNSTopic_policy (14.15s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (14.24s)
--- PASS: TestAccAWSSNSTopic_importBasic (14.45s)
--- PASS: TestAccAWSSNSTopic_encryption (21.29s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (23.82s)
--- PASS: TestAccAWSSNSTopic_tags (31.08s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (34.24s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (130.75s)

Output from acceptance testing (AWS GovCloud (US)) (test failure unrelated):

--- PASS: TestAccAWSSNSTopic_namePrefix (17.66s)
--- PASS: TestAccAWSSNSTopic_basic (17.94s)
--- PASS: TestAccAWSSNSTopic_name (18.01s)
--- PASS: TestAccAWSSNSTopic_policy (18.56s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (18.67s)
--- PASS: TestAccAWSSNSTopic_importBasic (19.54s)
--- PASS: TestAccAWSSNSTopic_encryption (30.82s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (31.66s)
--- PASS: TestAccAWSSNSTopic_tags (42.24s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (133.78s)
--- FAIL: TestAccAWSSNSTopic_deliveryStatus (136.70s)
    testing.go:568: Step 0 error: errors during apply:

        Error: InvalidParameter: Invalid parameter: AttributeName Reason: HTTPSuccessFeedbackRoleArn is not a supported AttributeName

@bflad bflad merged commit 5b3dd8c into hashicorp:master May 14, 2019
bflad added a commit that referenced this pull request May 14, 2019
@bflad
Copy link
Contributor

bflad commented May 17, 2019

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon SNS topic tagging
2 participants