Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sfn_state_machine: Bypass UnknownOperationException error for ListTagsForResource #8467

Merged
merged 1 commit into from
May 2, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 27, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8450

Verified against LocalStack:

aws_sfn_state_machine.state_machine: Creating...
  creation_date: "" => "<computed>"
  definition:    "" => "{\n  \"StartAt\": \"finish\",\n  \"States\": {\n    \"finish\": {\n      \"Type\": \"Succeed\"\n    }\n  }\n}\n"
  name:          "" => "machine"
  role_arn:      "" => "arn:aws:iam::123123123123:role/some_role"
  status:        "" => "<computed>"
aws_sfn_state_machine.state_machine: Creation complete after 0s (ID: arn:aws:states:us-east-1:000000000000:stateMachine:machine)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Output from acceptance testing (update eventual consistency test error is also present on master):

--- FAIL: TestAccAWSSfnStateMachine_createUpdate (38.23s)
    testing.go:568: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-weedqxml47\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnStateMachine_Tags (53.08s)

…r for ListTagsForResource

Reference: #8450

Verified against LocalStack:

```
aws_sfn_state_machine.state_machine: Creating...
  creation_date: "" => "<computed>"
  definition:    "" => "{\n  \"StartAt\": \"finish\",\n  \"States\": {\n    \"finish\": {\n      \"Type\": \"Succeed\"\n    }\n  }\n}\n"
  name:          "" => "machine"
  role_arn:      "" => "arn:aws:iam::123123123123:role/some_role"
  status:        "" => "<computed>"
aws_sfn_state_machine.state_machine: Creation complete after 0s (ID: arn:aws:states:us-east-1:000000000000:stateMachine:machine)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
```

Output from acceptance testing (eventual consistency error is also present on master):

```
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (38.23s)
    testing.go:568: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-weedqxml47\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnStateMachine_Tags (53.08s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. labels Apr 27, 2019
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 27, 2019
@nywilken nywilken added this to the v2.9.0 milestone May 2, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit 402db8f into master May 2, 2019
@nywilken nywilken deleted the f-aws_sfn_state_machine-localstack branch May 2, 2019 02:19
alejandrocena added a commit to alejandrocena/aws-localstack-terraform-stepfunctions-lambda that referenced this pull request May 5, 2019
bflad added a commit that referenced this pull request May 6, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with stepfunctions-local / localstack
2 participants