r/aws_dx_gateway_association: Allowed prefix support #8222

ewbankkit · 2019-04-05T22:29:54Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

ewbankkit · 2019-04-05T22:30:27Z

Current acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_basic -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_basic
=== PAUSE TestAccAwsDxGatewayAssociation_basic
=== CONT  TestAccAwsDxGatewayAssociation_basic
--- FAIL: TestAccAwsDxGatewayAssociation_basic (1239.62s)
    testing.go:538: Step 0 error: After applying this step and refreshing, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_dx_gateway_association.test
          allowed_prefixes.#:          "1" => "0"
          allowed_prefixes.1216997074: "10.255.255.0/28" => ""
        
        STATE:
        
        aws_dx_gateway.test:
          ID = 1a8ca6fb-bbfc-4e3d-ac7f-da8bec989173
          provider = provider.aws
          amazon_side_asn = 65362
          name = terraform-testacc-dxgwassoc-1463777356999477301
        aws_dx_gateway_association.test:
          ID = ga-1a8ca6fb-bbfc-4e3d-ac7f-da8bec989173vgw-09d41462383e45e80
          provider = provider.aws
          allowed_prefixes.# = 1
          allowed_prefixes.1216997074 = 10.255.255.0/28
          dx_gateway_association_id = 5297e438-a084-435a-afd7-b6b4c4dae015
          dx_gateway_id = 1a8ca6fb-bbfc-4e3d-ac7f-da8bec989173
          vpn_gateway_id = vgw-09d41462383e45e80
        
          Dependencies:
            aws_dx_gateway.test
            aws_vpn_gateway_attachment.test
        aws_vpc.test:
          ID = vpc-0c35d0d9035c6ffe2
          provider = provider.aws
          arn = arn:aws:ec2:us-west-2:346386234494:vpc/vpc-0c35d0d9035c6ffe2
          assign_generated_ipv6_cidr_block = false
          cidr_block = 10.255.255.0/28
          default_network_acl_id = acl-0d932fbe72553c2d5
          default_route_table_id = rtb-0f5e45ab5fa9bae1e
          default_security_group_id = sg-05e844d9132964d03
          dhcp_options_id = dopt-249eba40
          enable_classiclink = false
          enable_classiclink_dns_support = false
          enable_dns_hostnames = false
          enable_dns_support = true
          instance_tenancy = default
          ipv6_association_id = 
          ipv6_cidr_block = 
          main_route_table_id = rtb-0f5e45ab5fa9bae1e
          owner_id = 346386234494
          tags.% = 1
          tags.Name = terraform-testacc-dxgwassoc-1463777356999477301
        aws_vpn_gateway.test:
          ID = vgw-09d41462383e45e80
          provider = provider.aws
          amazon_side_asn = 64512
          tags.% = 1
          tags.Name = terraform-testacc-dxgwassoc-1463777356999477301
          vpc_id = vpc-0c35d0d9035c6ffe2
        aws_vpn_gateway_attachment.test:
          ID = vpn-attachment-8937c7e5
          provider = provider.aws
          vpc_id = vpc-0c35d0d9035c6ffe2
          vpn_gateway_id = vgw-09d41462383e45e80
        
          Dependencies:
            aws_vpc.test
            aws_vpn_gateway.test
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1239.658s
GNUmakefile:20: recipe for target 'testacc' failed
make: *** [testacc] Error 1

bflad · 2019-04-16T01:47:13Z

aws/resource_aws_dx_gateway_association.go


 		Schema: map[string]*schema.Schema{
+			"allowed_prefixes": {


I think it is okay to mark this as Computed: true for now, given that it automatically includes the VPC CIDR if no prefixes are provided. 👍

Done, I think a missing call to resourceAwsDxGatewayAssociationRead() at the end of resourceAwsDxGatewayAssociationCreate() doesn't help either 😄.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_basic -timeout 120m === RUN TestAccAwsDxGatewayAssociation_basic === PAUSE TestAccAwsDxGatewayAssociation_basic === CONT TestAccAwsDxGatewayAssociation_basic --- PASS: TestAccAwsDxGatewayAssociation_basic (943.05s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 943.077s

ewbankkit · 2019-04-22T01:25:28Z

Removed WIP.
Ready for review.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_basic -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_basic
=== PAUSE TestAccAwsDxGatewayAssociation_basic
=== CONT  TestAccAwsDxGatewayAssociation_basic
--- PASS: TestAccAwsDxGatewayAssociation_basic (943.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	943.077s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxGatewayAssociation_allowedPrefixes'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxGatewayAssociation_allowedPrefixes -timeout 120m
=== RUN   TestAccAwsDxGatewayAssociation_allowedPrefixes
=== PAUSE TestAccAwsDxGatewayAssociation_allowedPrefixes
=== CONT  TestAccAwsDxGatewayAssociation_allowedPrefixes
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixes (1379.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1379.232s

bflad

This looks great, thanks @ewbankkit! 🚀 Two very minor documentation changes below will be handled on merge.

Output from acceptance testing (aside: the multiVgws test is very flakey, likely due to some missing retry logic the aws_vpn_gateway resource, but unrelated to this PR):

--- PASS: TestAccAwsDxGatewayAssociation_basic (1197.11s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixes (1719.97s)

bflad · 2019-04-24T12:41:17Z

website/docs/r/dx_gateway_association.html.markdown

+}
+
+resource "aws_vpn_gateway" "example" {
+  vpc_id = "${aws_vpc.test.id}"


Suggested change

vpc_id = "${aws_vpc.test.id}"

vpc_id = "${aws_vpc.example.id}"

bflad · 2019-04-24T12:46:23Z

website/docs/r/dx_gateway_association.html.markdown

 * `vpn_gateway_id` - (Required) The ID of the VGW with which to associate the gateway.
+* `allowed_prefixes` - (Optional) The Amazon VPC prefixes to advertise to the Direct Connect gateway.


Minor improvements here for clarification:

Suggested change

* `allowed_prefixes` - (Optional) The Amazon VPC prefixes to advertise to the Direct Connect gateway.

* `allowed_prefixes` - (Optional) VPC prefixes (CIDRs) to advertise to the Direct Connect gateway. Defaults to the CIDR block of the VPC associated with the Virtual Gateway. To enable drift detection, must be configured.

… feedback Reference: #8222 (review)

ewbankkit · 2019-04-24T16:59:31Z

@bflad Yes, when I ran the tests in parallel in my account I regularly got timeouts on the gateway disassociation but no problems when running serially.
Thanks for cleaning up the doc. Copy pasta.

nywilken · 2019-04-27T01:43:12Z

This has been released in version 2.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-03-30T17:31:56Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

r/aws_dx_gateway_association: Allowed prefix support.

191e73f

bflad reviewed Apr 16, 2019

View reviewed changes

bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Apr 16, 2019

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 19, 2019

ewbankkit force-pushed the issue-8199 branch from 75c747a to 15a3042 Compare April 21, 2019 21:17

Add Direct Connect gateway association allow prefix acceptance tests.

c1021a3

ewbankkit force-pushed the issue-8199 branch from 15a3042 to c1021a3 Compare April 21, 2019 22:24

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 22, 2019

ewbankkit changed the title ~~[WIP] r/aws_dx_gateway_association: Allowed prefix support~~ r/aws_dx_gateway_association: Allowed prefix support Apr 22, 2019

bflad added this to the v2.8.0 milestone Apr 24, 2019

bflad approved these changes Apr 24, 2019

View reviewed changes

bflad merged commit c1021a3 into hashicorp:master Apr 24, 2019

bflad added a commit that referenced this pull request Apr 24, 2019

docs/resource/aws_dx_gateway_association: Minor fixes based on PR #8320…

84f54d9

… feedback Reference: #8222 (review)

bflad added a commit that referenced this pull request Apr 24, 2019

Update CHANGELOG for #8222

f0625ff

ewbankkit deleted the issue-8199 branch April 24, 2019 16:59

This was referenced May 8, 2019

[WIP] Second half of support for Gateway Association Proposals #8455

Closed

aws_vpn_gateway and aws_vpn_gateway_attachment incorrectly refreshing attachment state #8575

Closed

ewbankkit mentioned this pull request May 24, 2019

Breaking change for aws_dx_gateway_association vpn_gateway_id parameter #8773

Closed

ghost locked and limited conversation to collaborators Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_dx_gateway_association: Allowed prefix support #8222

r/aws_dx_gateway_association: Allowed prefix support #8222

ewbankkit commented Apr 5, 2019

ewbankkit commented Apr 5, 2019

bflad Apr 16, 2019

ewbankkit Apr 21, 2019

ewbankkit Apr 21, 2019

ewbankkit commented Apr 22, 2019

bflad left a comment

bflad Apr 24, 2019

bflad Apr 24, 2019

ewbankkit commented Apr 24, 2019

nywilken commented Apr 27, 2019

ghost commented Mar 30, 2020

	vpc_id = "${aws_vpc.test.id}"
	vpc_id = "${aws_vpc.example.id}"

		* `vpn_gateway_id` - (Required) The ID of the VGW with which to associate the gateway.
		* `allowed_prefixes` - (Optional) The Amazon VPC prefixes to advertise to the Direct Connect gateway.

	* `allowed_prefixes` - (Optional) The Amazon VPC prefixes to advertise to the Direct Connect gateway.
	* `allowed_prefixes` - (Optional) VPC prefixes (CIDRs) to advertise to the Direct Connect gateway. Defaults to the CIDR block of the VPC associated with the Virtual Gateway. To enable drift detection, must be configured.

r/aws_dx_gateway_association: Allowed prefix support #8222

r/aws_dx_gateway_association: Allowed prefix support #8222

Conversation

ewbankkit commented Apr 5, 2019

Community Note

ewbankkit commented Apr 5, 2019

bflad Apr 16, 2019

Choose a reason for hiding this comment

ewbankkit Apr 21, 2019

Choose a reason for hiding this comment

ewbankkit Apr 21, 2019

Choose a reason for hiding this comment

ewbankkit commented Apr 22, 2019

bflad left a comment

Choose a reason for hiding this comment

bflad Apr 24, 2019

Choose a reason for hiding this comment

bflad Apr 24, 2019

Choose a reason for hiding this comment

ewbankkit commented Apr 24, 2019

nywilken commented Apr 27, 2019

ghost commented Mar 30, 2020