r/kinesis_analytics_application: Support import

[atsushi-ishibashi]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7549

Changes proposed in this pull request:

• aws_kinesis_analytics_application supports import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_basic'
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_basic -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (33.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.450s

[bflad]

Can you please add this TestStep to the majority of the other acceptance tests so we can ensure we are properly able to import all configurations? Thanks.

[atsushi-ishibashi]

TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (31.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (51.40s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (58.81s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (71.59s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (74.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (83.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (86.64s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (117.99s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (119.98s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (124.08s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (131.99s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (145.78s)
--- FAIL: TestAccAWSKinesisAnalyticsApplication_inputsAdd (149.07s)
    testing.go:599: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Check failed: Error: Application still exists
        
        State: <no state>
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (151.82s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (229.70s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (230.27s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	230.322s

TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_inputsAdd -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (163.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	163.726s

[bflad]

Looks good, thanks @atsushi-ishibashi! 🚀

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (10.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (15.13s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (26.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (29.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (35.48s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (35.55s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (36.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (50.34s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (88.83s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (88.83s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (88.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (104.87s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (110.69s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (118.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (172.64s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (195.96s)

[bflad]

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!