-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to Putting in Description for Launch Template Resource #7569
Fix to Putting in Description for Launch Template Resource #7569
Conversation
aws/resource_aws_launch_template.go
Outdated
@@ -47,6 +47,7 @@ func resourceAwsLaunchTemplate() *schema.Resource { | |||
"description": { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
Default: "Managed by Terraform", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should skip adding our own default here. 👍 Its an old practice and will cause unexpected differences for existing Terraform configurations when added like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bflad Thanks. I removed default description
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kterada0509 🚀
--- PASS: TestAccAWSLaunchTemplate_basic (8.38s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (45.99s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (43.07s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (9.24s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (14.43s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (7.62s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (9.94s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (9.77s)
--- PASS: TestAccAWSLaunchTemplate_data (7.80s)
--- PASS: TestAccAWSLaunchTemplate_description (15.76s)
--- PASS: TestAccAWSLaunchTemplate_disappears (5.88s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (36.37s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (9.92s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (10.89s)
--- PASS: TestAccAWSLaunchTemplate_importData (8.82s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (79.66s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (11.26s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (27.41s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (7.68s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (7.83s)
--- PASS: TestAccAWSLaunchTemplate_tags (17.45s)
--- PASS: TestAccAWSLaunchTemplate_update (51.31s)
This has been released in version 1.60.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #7510
Changes proposed in this pull request:
Output from acceptance testing: