Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Putting in Description for Launch Template Resource #7569

Conversation

teraken0509
Copy link
Contributor

Fixes #7510

Changes proposed in this pull request:

  • Fixed parameters to putting description
  • Add default value for description

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_basic -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_basic
--- PASS: TestAccAWSLaunchTemplate_basic (27.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.682s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_description'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_description -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== CONT  TestAccAWSLaunchTemplate_description
--- PASS: TestAccAWSLaunchTemplate_description (43.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.367s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 15, 2019
@@ -47,6 +47,7 @@ func resourceAwsLaunchTemplate() *schema.Resource {
"description": {
Type: schema.TypeString,
Optional: true,
Default: "Managed by Terraform",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should skip adding our own default here. 👍 Its an old practice and will cause unexpected differences for existing Terraform configurations when added like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad Thanks. I removed default description

@bflad bflad added bug Addresses a defect in current functionality. waiting-response Maintainers are waiting on response from community or contributor. labels Feb 21, 2019
@teraken0509
Copy link
Contributor Author

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_description'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_description -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== CONT  TestAccAWSLaunchTemplate_description
--- PASS: TestAccAWSLaunchTemplate_description (43.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.551s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Feb 22, 2019
@bflad bflad added this to the v1.60.0 milestone Feb 22, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSLaunchTemplate_basic (8.38s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (45.99s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (43.07s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (9.24s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (14.43s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (7.62s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (9.94s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (9.77s)
--- PASS: TestAccAWSLaunchTemplate_data (7.80s)
--- PASS: TestAccAWSLaunchTemplate_description (15.76s)
--- PASS: TestAccAWSLaunchTemplate_disappears (5.88s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (36.37s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (9.92s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (10.89s)
--- PASS: TestAccAWSLaunchTemplate_importData (8.82s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (79.66s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (11.26s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (27.41s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (7.68s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (7.83s)
--- PASS: TestAccAWSLaunchTemplate_tags (17.45s)
--- PASS: TestAccAWSLaunchTemplate_update (51.31s)

@bflad bflad merged commit ffaf5c7 into hashicorp:master Feb 22, 2019
bflad added a commit that referenced this pull request Feb 22, 2019
@bflad
Copy link
Contributor

bflad commented Feb 22, 2019

This has been released in version 1.60.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-description-support-for-launch-template branch February 27, 2019 01:24
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch Template Not Putting in Description
2 participants