resource/aws_iot_topic_rule: Fix optional attributes

[nywilken]

Terraform requires arguments that are optional when creating aws_iot_topic_rule

Logged POST request before update

$ TF_LOG_PATH=log.txt TF_LOG=debug TF_ACC=1 go test ./aws -v -timeout 120m -parallel 10 -run=TestAccAWSIoTTopicRule_basic                                     
                                                                                                                                                              
2019/02/08 12:48:15 [DEBUG] [aws-sdk-go] DEBUG: Request iot/CreateTopicRule Details:                                                                          
---[ REQUEST POST-SIGN ]-----------------------------                                                                                                         POST /rules/test_rule_nlzsp HTTP/1.1
[...]
{"actions":[{"dynamoDB":{"hashKeyField":"hash_key_field","hashKeyValue":"hash_key_value","payloadField":"payload_field","rangeKeyField":"range_key_field","rangeKeyValue":"range_key_value","roleArn":"arn:aws:iam::187416307283:role/test_role_nlzsp","tableName":"table_name"}}],"awsIotSqlVersion":"2015-10-08","description":"Example rule","ruleDisabled":false,"sql":"SELECT * FROM 'topic/test'"} 
-----------------------------------------------------
2019/02/08 12:48:15 [DEBUG] [aws-sdk-go] DEBUG: Response iam/CreatePolicy Details: 
---[ RESPONSE ]--------------------------------------
HTTP/1.1 200 OK^M                                                                                                                                             

Logged POST request after update

$TF_LOG_PATH=log.txt TF_LOG=debug TF_ACC=1 go test ./aws -v -timeout 120m -parallel 10 -run=TestAccAWSIoTTopicRule_dynamodb 
2019/02/08 12:54:28 [DEBUG] [aws-sdk-go] DEBUG: Request iot/CreateTopicRule Details:
---[ REQUEST POST-SIGN ]-----------------------------
POST /rules/test_rule_6qq07 HTTP/1.1
[...]
{"actions":[{"dynamoDB":{"hashKeyField":"hash_key_field","hashKeyValue":"hash_key_value","payloadField":"payload_field","roleArn":"arn:aws:iam::187416307283:role/test_role_6qq07","tableName":"table_name"}}],"awsIotSqlVersion":"2015-10-08","description":"Example rule","ruleDisabled":false,"sql":"SELECT * FROM 'topic/test'"}
-----------------------------------------------------
2019/02/08 12:54:28 [DEBUG] [aws-sdk-go] DEBUG: Response iam/GetPolicyVersion Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 200 OK

closes #6195

[nywilken]

@bflad I made a few additional updates along with the added test case. Please let me know if there is anything that I may have missed.

[bflad]

Getting very close! This looks fine, I just want to be sure we're appropriately covering both configured and unconfigured scenarios to prevent regressions in the future.

[bflad]

LGTM, thanks @nywilken! 🚀

--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (10.73s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (10.85s)
--- PASS: TestAccAWSIoTTopicRule_basic (10.95s)
--- PASS: TestAccAWSIoTTopicRule_lambda (11.02s)
--- PASS: TestAccAWSIoTTopicRule_firehose (11.12s)
--- PASS: TestAccAWSIoTTopicRule_republish (11.06s)
--- PASS: TestAccAWSIoTTopicRule_sqs (11.14s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (11.74s)
--- PASS: TestAccAWSIoTTopicRule_sns (11.97s)
--- PASS: TestAccAWSIoTTopicRule_importbasic (12.09s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (12.25s)
--- PASS: TestAccAWSIoTTopicRule_s3 (12.65s)
--- PASS: TestAccAWSIoTTopicRule_dynamodb (15.98s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (16.02s)

[bflad]

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!