resource/aws_route53_zone: Support multiple vpc associations, deprecate vpc_id and vpc_region, and enhance acceptance testing #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
enhancement
ghost
added
size/XXL
…te vpc_id and vpc_region, and enhance acceptance testing Changes: * Add `vpc` TypeSet attribute to support exclusive management and import of multiple VPC associations * Deprecate `vpc_id` and `vpc_region` attributes in favor of `vpc`, adding note to Version 2 Upgrade Guide * Refactor Create/Read/Update/Delete to return error message context, use AWS Go SDK helpers to prevent panics, always call d.Set(), and use isAWSErr() * Add acceptance testing for delegation_set_id attribute * Enhance acceptance testing for tags to test updates * Migrate _importBasic acceptance test to Import TestStep in all acceptance tests Output from acceptance testing: ``` --- PASS: TestAccAWSRoute53Zone_basic (73.02s) --- PASS: TestAccAWSRoute53Zone_VPCRegion (73.44s) --- PASS: TestAccAWSRoute53Zone_DelegationSetID (76.95s) --- PASS: TestAccAWSRoute53Zone_Comment (81.43s) --- PASS: TestAccAWSRoute53Zone_VPCID (82.88s) --- PASS: TestAccAWSRoute53Zone_multiple (84.98s) --- PASS: TestAccAWSRoute53Zone_VPC_Single (88.03s) --- PASS: TestAccAWSRoute53Zone_Tags (91.95s) --- PASS: TestAccAWSRoute53Zone_VPC_Multiple (140.49s) --- PASS: TestAccAWSRoute53Zone_VPC_Updates (226.21s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy (249.03s) --- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (249.05s) ```
bflad
force-pushed
the
f-aws_route53_zone-vpc
branch
from
8a205f9 to
7351b74
Compare
alexsomesan
approved these changes
Oct 30, 2018
|
This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route53 Hosted Zones can have multiple VPC associations. Previously, the resource would error when attempting to import a zone with multiple associations. I wasn't planning on this large refactoring but trying to get the other changes in highlighted the need to bring this resource up to more current practices.
Closes #892
Closes #5317
Closes #5736
Changes:
vpcTypeSet attribute to support exclusive management and import of multiple VPC associationsvpc_idandvpc_regionattributes in favor ofvpc, adding note to Version 2 Upgrade GuideOutput from acceptance testing: