Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lb_listener(_rule): Set action order to Computed #6119

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 11, 2018

Fixes #6116

While the acceptance testing is not finding this scenario, the order value may return as 1. This may be caused by web console updates. We should not default this to 1 as that could cause 0 to 1 plan differences and shying away from a stopgap DiffSuppressFunc here because we may make this configuration based on the TypeList index in the future if its undefined.

Changes proposed in this pull request:

  • resource/aws_lb_listener: Set default_action order to Computed
  • resource/aws_lb_listener_rule: Set action order to Computed

Output from acceptance testing:

15 tests passed (all tests)
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.63s)
--- PASS: TestAccAWSLBListener_oidc (191.06s)
--- PASS: TestAccAWSLBListener_basic (198.17s)
--- PASS: TestAccAWSLBListener_redirect (199.97s)
--- PASS: TestAccAWSLBListenerRule_basic (202.39s)
--- PASS: TestAccAWSLBListenerRule_cognito (202.91s)
--- PASS: TestAccAWSLBListener_https (207.19s)
--- PASS: TestAccAWSLBListener_cognito (208.68s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (219.09s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (240.27s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (246.74s)
--- PASS: TestAccAWSLBListener_fixedResponse (255.55s)
--- PASS: TestAccAWSLBListenerRule_priority (281.37s)
--- PASS: TestAccAWSLBListenerRule_redirect (281.80s)
--- PASS: TestAccAWSLBListenerRule_oidc (318.27s)

bflad added 2 commits October 10, 2018 20:45
While the acceptance testing is not finding this scenario, the order value may return as 1. This may be caused by web console updates.
While the acceptance testing is not finding this scenario, the order value may return as 1. This may be caused by web console updates.
@bflad bflad added bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Oct 11, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 11, 2018
@bflad bflad requested a review from a team October 11, 2018 01:11
@bflad bflad added this to the v1.41.0 milestone Oct 11, 2018
@bflad bflad merged commit 4abfee7 into master Oct 11, 2018
@bflad bflad deleted the b-aws_lb_listener_rule-order branch October 11, 2018 15:12
bflad added a commit that referenced this pull request Oct 12, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lb_listener_rule action implicit order is broken
2 participants