resource/aws_network_interface_sg_attachment: Properly handle InvalidNetworkInterfaceID.NotFound errors #6048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
bug
ghost
added
size/XL
…NetworkInterfaceID.NotFound errors
Changes:
* Refactor `aws_network_interface_sg_attachments` acceptance testing to align with other resources
* Add `testAccCheckAWSENIDisappears`
* Add `TestAccAWSNetworkInterfaceSGAttachment_disappears` acceptance test for verifying error handling
* Ensure `aws_network_interface_sg_attachment` resource removes resource during Read and exits successfully during Delete if it receives `InvalidNetworkInterfaceID.NotFound` error
Previously (before code updates):
```
--- PASS: TestAccAWSENI_disappears (35.81s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (33.03s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (34.00s)
--- FAIL: TestAccAWSNetworkInterfaceSGAttachment_disappears (41.18s)
testing.go:527: Step 1 error: Error on follow-up refresh: 1 error occurred:
* aws_network_interface_sg_attachment.test: 1 error occurred:
* aws_network_interface_sg_attachment.test: aws_network_interface_sg_attachment.test: InvalidNetworkInterfaceID.NotFound: The networkInterface ID 'eni-06f5470ea633d8b1c' does not exist
status code: 400, request id: 8f424390-cf91-4ef7-9d03-ed6e8711244c
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (113.03s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (119.99s)
```
Now:
```
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Multiple (33.00s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_basic (35.31s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_disappears (50.21s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_DataSource (115.76s)
--- PASS: TestAccAWSNetworkInterfaceSGAttachment_Instance (131.26s)
```
bflad
force-pushed
the
b-aws_network_interface_sg_attachment-disappears
branch
from
748658b to
3219a0d
Compare
paultyng
approved these changes
Oct 3, 2018
|
This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "aws" {
version = "~> 1.39.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1796
Changes:
aws_network_interface_sg_attachmentsacceptance testing to align with other resourcestestAccCheckAWSENIDisappearsTestAccAWSNetworkInterfaceSGAttachment_disappearsacceptance test for verifying error handlingaws_network_interface_sg_attachmentresource removes resource during Read and exits successfully during Delete if it receivesInvalidNetworkInterfaceID.NotFounderrorPreviously (before code updates):
Output from acceptance testing: