Update aws_launch_template schema(ipv6 addr count)

[iamjarvo]

Change ipv6_address_count from computed to optional

Changes proposed in this pull request:

• Change ipv6_address_count from computed to true - aws/resource_aws_launch_template.go

Output from acceptance testing:

make test                                                                                                    
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws       6.339s
...

Example of this working with the aws cli

aws ec2 create-launch-template --launch-template-name example-template --version-description WebVersion1 --launch-template-data '{"NetworkInterfaces":[{"Ipv6AddressCount":1,"SubnetId":"a-subnet"}],"ImageId":"123444","InstanceType":"t2.small","TagSpecifications":[{"ResourceType":"instance","Tags":[{"Key":"Name","Value":"webserver"}]}]}'

[bflad]

Hi @iamjarvo 👋 Thank you for submitting this. Can you please provide an acceptance test or self-contained configuration that shows successful usage of this new argument? It will help speed up getting this pull request merged. Thanks!

[iamjarvo]

@bflad will write a test. Need to take a look at how the tests work. I think this will help me https://www.terraform.io/docs/extend/testing/acceptance-tests/index.html

[bflad]

See also: #5830 (I would suggest working together)

[kl4w]

@iamjarvo my bad for not seeing your PR. cos you already started ipv6 portion, i'll change my PR to just address the ipv4 yeah?

[iamjarvo]

@kl4w sounds good! I should opened an issue for visibility

[iamjarvo]

 make testacc TESTARGS=-run=TestAccAWSLaunchTemplate_networkInterface_ipv6_count
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSLaunchTemplate_networkInterface_ipv6_count -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6_count
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6_count (12.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       16.617s

@bflad wrote a test

[bflad]

LGTM, thanks @iamjarvo! 🚀

--- PASS: TestAccAWSLaunchTemplate_data (4.65s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (5.24s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (6.99s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (7.39s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6_count (7.45s)
--- PASS: TestAccAWSLaunchTemplate_basic (7.61s)
--- PASS: TestAccAWSLaunchTemplate_importData (7.64s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (7.79s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (8.01s)
--- PASS: TestAccAWSLaunchTemplate_tags (10.55s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (12.21s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (36.54s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (39.92s)
--- PASS: TestAccAWSLaunchTemplate_update (45.58s)

[bflad]

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!