Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Disable AWS SDK retries faster by default for connection refused errors #5614

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 20, 2018

When using resource.Retry(), this error is sometimes never displayed except for the Terraform debug logs due to the AWS SDK never returning the response before the resource.Retry() timeout:

* aws_dynamodb_table.mda-table: timeout while waiting for state to become 'success' (timeout: 2m0s)

This type of error is more permanent in nature and should be returned quicker than the default MaxRetries configuration of the provider.

Reference: #5599

Changes proposed in this pull request:

  • Disable Retryable for connection refused errors sooner if using default MaxRetries configuration

Output from acceptance testing: Handled via daily acceptance testing

…fused errors

When using `resource.Retry()`, this error is sometimes never displayed except for the Terraform debug logs due to the AWS SDK never returning the response before the `resource.Retry()` timeout:

```
* aws_dynamodb_table.mda-table: timeout while waiting for state to become 'success' (timeout: 2m0s)
```

This type of error is more permanent in nature and should be returned quicker than the default MaxRetries configuration of the provider.
@bflad bflad added bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. labels Aug 20, 2018
@bflad bflad requested a review from a team August 20, 2018 17:01
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Aug 20, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.33.0 milestone Aug 21, 2018
@bflad bflad merged commit 8d9a519 into master Aug 21, 2018
@bflad bflad deleted the b-provider-connection-refused branch August 21, 2018 13:05
bflad added a commit that referenced this pull request Aug 21, 2018
@bflad
Copy link
Contributor Author

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants