New Resource: aws_neptune_cluster_snapshot

[bflad]

For future support of a Neptune cluster snapshot data source and restoring Neptune clusters from snapshot.

Changes proposed in this pull request:

• New Resource: aws_neptune_cluster_snapshot

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneClusterSnapshot_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNeptuneClusterSnapshot_basic -timeout 120m
=== RUN   TestAccAWSNeptuneClusterSnapshot_basic
--- PASS: TestAccAWSNeptuneClusterSnapshot_basic (188.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	188.877s

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

minor refactor you could probably invert this if statement if you wanted, since we return nil below anyway

[bflad]

That's definitely a reasonable ask! We've tended to follow the following structure throughout the project (deletion functions, read functions, resource.Retry functions):

if err != nil {
  // optional :)
  if isAWSErr(err, ..., ...) {
    return nil // or return resource.RetryableError(err)
  }
  return err // or return resource.NonRetryableError(err)
}
// ...
return nil

At some point we probably should follow the "left alignment for readability" principle a little better, e.g.

// optional :)
if isAWSErr(err, ..., ...) {
  return nil // or return resource.RetryableError(err)
}
if err != nil {
  return err // or return resource.NonRetryableError(err)
}
// ...
return nil

I'm not sure if its worth tackling all at once or piecemeal though. Definitely open to suggestions.

[bflad]

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!