Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_vpn_gateway: Handle additional legacy Amazon ASNs #5441

Merged
merged 1 commit into from
Aug 3, 2018
Merged

r/aws_vpn_gateway: Handle additional legacy Amazon ASNs #5441

merged 1 commit into from
Aug 3, 2018

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 3, 2018 •
edited
Loading

Fixes #5263 (comment).

Additional legacy Amazon ASNs:

  • Asia Pacific (Tokyo) - 10124
  • Asia Pacific (Singapore) - 17493

Unit tests:

$ go test -timeout 30s github.com/terraform-providers/terraform-provider-aws/aws -run ^TestValidateVpnGatewayAmazonSideAsn$
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.009s
 go test -timeout 30s github.com/terraform-providers/terraform-provider-aws/aws -run ^TestValidateDxGatewayAmazonSideAsn$
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.009s

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Aug 3, 2018
@ewbankkit
Copy link
Contributor Author

Follows on from #5291.

@bflad bflad added this to the v1.31.0 milestone Aug 3, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 3, 2018
@bflad bflad merged commit 685deb4 into hashicorp:master Aug 3, 2018
bflad added a commit that referenced this pull request Aug 3, 2018
@bflad
Update CHANGELOG for #5441
f4778b0
@ewbankkit ewbankkit deleted the issue-5263-redux branch August 3, 2018 14:14
@bflad
Copy link
Contributor

bflad commented Aug 9, 2018

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@sharathrnair87 sharathrnair87 mentioned this pull request Oct 23, 2018
Closed
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

issue with vpn_gateway and amazon_side_asn
2 participants
@ewbankkit @bflad