Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add import for aws_eip_association #5006

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Jun 27, 2018

Fixes #4876

Changes proposed in this pull request:

  • Add import to aws_eip_association

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEIPAssociation_import'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEIPAssociation_import -timeout 120m
=== RUN   TestAccAWSEIPAssociation_importInstance
--- PASS: TestAccAWSEIPAssociation_importInstance (243.58s)
=== RUN   TestAccAWSEIPAssociation_importNetworkInterface
--- PASS: TestAccAWSEIPAssociation_importNetworkInterface (39.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	283.357s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jun 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 27, 2018
@bflad bflad added this to the v1.26.0 milestone Jun 27, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kl4w! Looks good! 🚀

6 tests passed (all tests)
=== RUN   TestAccAWSEIPAssociation_importNetworkInterface
--- PASS: TestAccAWSEIPAssociation_importNetworkInterface (20.44s)
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (98.17s)
=== RUN   TestAccAWSEIPAssociation_disappears
--- PASS: TestAccAWSEIPAssociation_disappears (183.98s)
=== RUN   TestAccAWSEIPAssociation_ec2Classic
--- PASS: TestAccAWSEIPAssociation_ec2Classic (199.95s)
=== RUN   TestAccAWSEIPAssociation_importInstance
--- PASS: TestAccAWSEIPAssociation_importInstance (210.97s)
=== RUN   TestAccAWSEIPAssociation_spotInstance
--- PASS: TestAccAWSEIPAssociation_spotInstance (246.40s)

@bflad bflad merged commit 048256a into hashicorp:master Jun 27, 2018
bflad added a commit that referenced this pull request Jun 27, 2018
@kl4w kl4w deleted the import_eip_association branch June 28, 2018 00:02
@bflad
Copy link
Contributor

bflad commented Jul 4, 2018

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: resource aws_eip_association doesn't support import
2 participants