Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_vpc_endpoint_service: GovCloud doesn't respect the VPC Endpoint Service service names filter #4592

Merged
merged 1 commit into from
Jul 26, 2018
Merged

d/aws_vpc_endpoint_service: GovCloud doesn't respect the VPC Endpoint Service service names filter #4592

merged 1 commit into from
Jul 26, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #4398.

Restore the original response filtering code for GovCloud.

Acceptance tests (not in GovCloud):

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcEndpointService_gateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccDataSourceAwsVpcEndpointService_gateway -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpointService_gateway
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (14.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.727s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcEndpointService_interface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccDataSourceAwsVpcEndpointService_interface -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpointService_interface
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (14.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.185s

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 18, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 21, 2018
@lorengordon
Copy link
Contributor

I'm able to test pretty easily in GovCloud if someone can generate an executable for Windows.

@lorengordon
Copy link
Contributor

Sorry to bug you folks, just wanted to check if this was going to make it into a new release sometime soon?

@ewbankkit ewbankkit mentioned this pull request Jun 5, 2018
Closed
@lorengordon
Copy link
Contributor

lorengordon commented Jun 19, 2018 •
edited
Loading

@bflad Any chance this could get a review/merge? Currently stuck on v1.8.0 due to this bug, and keep running into other problems because I can't use features in newer versions. 😞

@ewbankkit
Copy link
Contributor Author

@bflad This has now been verified in cn. Can the PR be merged?

@mgresko
Copy link

mgresko commented Jul 19, 2018

Confirmed this works with govcloud

@cnluzhang
Copy link

Works well in cn region.

@mgresko
Copy link

mgresko commented Jul 24, 2018

@bflad Can this be merged? Working in govcloud without this we have to pin the provider to 1.8.0 which kills tons of newer features.

@bflad bflad added partition/aws-us-gov Pertains to the aws-us-gov partition. partition/aws-cn Pertains to the aws-cn partition. upstream Addresses functionality related to the cloud provider. labels Jul 26, 2018
@bflad bflad added this to the v1.29.0 milestone Jul 26, 2018
bflad
bflad approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here. 😅 Looks good to me.

@bflad bflad merged commit 45f42ee into hashicorp:master Jul 26, 2018
bflad added a commit that referenced this pull request Jul 26, 2018
@bflad
Update CHANGELOG for #4592
73fdfd8
@bflad
Copy link
Contributor

bflad commented Jul 26, 2018

This has been released in version 1.29.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit deleted the issue-4398 branch August 3, 2018 14:14
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

Error using data.aws_vpc_endpoint_service in AWS US GovCloud
5 participants
@ewbankkit @lorengordon @mgresko @cnluzhang @bflad