[issue-4217] AWS EMR: Force new resource if any of the EC2 attributes has changed #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddcprg
changed the title
bflad
added
service/emr
bflad
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
LGTM -- thanks! 🚀
Test failure unrelated:
=== RUN TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (463.00s)
=== RUN TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (530.86s)
=== RUN TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (561.61s)
=== RUN TestAccAWSEMRCluster_instance_group
--- PASS: TestAccAWSEMRCluster_instance_group (589.61s)
=== RUN TestAccAWSEMRCluster_security_config
--- PASS: TestAccAWSEMRCluster_security_config (595.67s)
=== RUN TestAccAWSEMRCluster_Step_Basic
--- PASS: TestAccAWSEMRCluster_Step_Basic (618.89s)
=== RUN TestAccAWSEMRCluster_s3Logging
--- PASS: TestAccAWSEMRCluster_s3Logging (627.19s)
=== RUN TestAccAWSEMRCluster_Step_Multiple
--- PASS: TestAccAWSEMRCluster_Step_Multiple (630.78s)
=== RUN TestAccAWSEMRCluster_custom_ami_id
--- PASS: TestAccAWSEMRCluster_custom_ami_id (649.10s)
=== RUN TestAccAWSEMRCluster_tags
--- FAIL: TestAccAWSEMRCluster_tags (711.89s)
=== RUN TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (721.76s)
=== RUN TestAccAWSEMRCluster_visibleToAllUsers
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (840.75s)
=== RUN TestAccAWSEMRCluster_root_volume_size
--- PASS: TestAccAWSEMRCluster_root_volume_size (991.24s)
bflad
added a commit
that referenced
this pull request
Apr 17, 2018
|
Cool! Thank you |
|
This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4217
I'm not sure whether the behaviour of the
ForceNewattribute has changed in Terraform. The attributeec2_attributesalready forces new resource so any changes in the children you be cascaded up to the parent attribute therefore trigger new resource creation. I've have configured the attribute for each child property for now.