Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iam_service_linked_role: Support custom_suffix and description arguments #4188

Merged
merged 2 commits into from
Apr 13, 2018
Merged

resource/aws_iam_service_linked_role: Support custom_suffix and description arguments #4188

merged 2 commits into from
Apr 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 12, 2018

Other goodies:

  • Attempts to remove elasticbeanstalk service linked role before basic test (should handle our acceptance test suite better)
  • Test sweeper for our custom suffix roles
make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMServiceLinkedRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSIAMServiceLinkedRole -timeout 120m
=== RUN   TestAccAWSIAMServiceLinkedRole_basic
--- PASS: TestAccAWSIAMServiceLinkedRole_basic (21.50s)
=== RUN   TestAccAWSIAMServiceLinkedRole_CustomSuffix
--- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix (20.92s)
=== RUN   TestAccAWSIAMServiceLinkedRole_Description
--- PASS: TestAccAWSIAMServiceLinkedRole_Description (27.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.699s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. labels Apr 12, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 12, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Apr 12, 2018
@bflad bflad requested a review from a team April 12, 2018 14:37
katbyte
katbyte approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 245fba0 into master Apr 13, 2018
@bflad bflad deleted the f-aws_iam_service_linked_role-customsuffix-description branch April 13, 2018 13:37
bflad added a commit that referenced this pull request Apr 13, 2018
@bflad
Update CHANGELOG for #4188
0c4009e
@bflad
Copy link
Contributor Author

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @katbyte