resource/aws_service_discovery_service: Support HealthCheckCustomConfig #4083
Conversation
|
Let me know if you have any comments on this one @atsushi-ishibashi :) |
jeffnappi
force-pushed
the
4082-service-discovery-service-health-check-custom
branch
from
a0f407d to
f4756e8
Compare
jeffnappi
force-pushed
the
4082-service-discovery-service-health-check-custom
branch
from
f4756e8 to
cd98402
Compare
jeffnappi
force-pushed
the
4082-service-discovery-service-health-check-custom
branch
from
cd98402 to
37d411b
Compare
jen20
added
enhancement
|
@bflad Is there anything else you'd like to see here? Thanks! |
|
I have verified that this PR does indeed fix the stated bug. Without it, I am unable to use Service Discovery with private tasks on Fargate. |
There was a problem hiding this comment.
Thanks @jeffnappi! 🚀 Pulling this in although I have some concerns we're not testing the mentioned failure scenario nor mentioning the issue in our documentation.
=== RUN TestAccAWSServiceDiscoveryService_import
--- PASS: TestAccAWSServiceDiscoveryService_import (12.49s)
=== RUN TestAccAWSServiceDiscoveryService_private
--- PASS: TestAccAWSServiceDiscoveryService_private (18.78s)
=== RUN TestAccAWSServiceDiscoveryService_public
--- PASS: TestAccAWSServiceDiscoveryService_public (22.17s)
|
This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
jeffnappi
deleted the
4082-service-discovery-service-health-check-custom
branch
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Adds HealthCheckCustomConfig support.
Setting HealcheckCustomConfig / Threshold to 1 is currently required for AWS Service Discovery to work properly.
Closes #4082