Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/r/api_gateway_vpc_link: target_arn -> target_arns #3569

Merged
merged 2 commits into from
Mar 1, 2018
Merged

docs/r/api_gateway_vpc_link: target_arn -> target_arns #3569

merged 2 commits into from
Mar 1, 2018

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Feb 28, 2018

Seems like we forgot to update document when changing target_arn to target_arns during implementation.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Feb 28, 2018
@loivis loivis force-pushed the docs-api-gateway-vpc-link branch from 1df3596 to a1006d0 Compare February 28, 2018 19:46
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Feb 28, 2018
@bflad bflad added the service/apigateway Issues and PRs that pertain to the apigateway service. label Feb 28, 2018
@bflad
Copy link
Contributor

bflad commented Feb 28, 2018

🙁 it looks like the Read function was not updated either: https://github.com/terraform-providers/terraform-provider-aws/blob/f1ffd5a4d34feab4d5fbe046588047c63f42b04a/aws/resource_aws_api_gateway_vpc_link.go#L95

Do you mind fixing that as well? No worries if not 👍

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. labels Feb 28, 2018
@bflad bflad added this to the v1.11.0 milestone Feb 28, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Feb 28, 2018
@bflad bflad self-requested a review February 28, 2018 22:22
bflad
bflad approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for submitting this!

=== RUN   TestAccAWSAPIGatewayVpcLink_basic
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (680.13s)

@bflad bflad merged commit 6f9518f into hashicorp:master Mar 1, 2018
bflad added a commit that referenced this pull request Mar 1, 2018
@bflad
Update CHANGELOG for #3569
e77fa3d
@loivis loivis deleted the docs-api-gateway-vpc-link branch March 1, 2018 08:35
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@loivis @bflad