resource/spot_fleet_request: validate arn for argument iam_fleet_role #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
enhancement
bflad
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
LGTM - Since the API documentation is not explicit about this, I have also verified that passing just the role name returns this API error, so ARN is required format:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotFleetRequest_instanceInterruptionBehavior'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSpotFleetRequest_instanceInterruptionBehavior -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
--- FAIL: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (608.35s)
testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
* aws_spot_fleet_request.foo: 1 error(s) occurred:
* aws_spot_fleet_request.foo: Error requesting spot fleet: [WARN] Error creating Spot fleet request, retrying: InvalidSpotFleetRequestConfig: Parameter: SpotFleetRequestConfig.IamFleetRole is invalid.test-role-lumds8e1i9 does not start with arn
status code: 400, request id: 48b3e0db-7526-4d92-9275-e95d2991fcfb
FAIL
exit status 1
FAIL github.com/terraform-providers/terraform-provider-aws/aws 608.393s
|
This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix #3430
I think it's sufficient to just validate format of arn, which the minimal change required for #3430 .