Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_emr_cluster: Retry creation on ValidationException (IAM) #3027

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

radeksimko
Copy link
Member

This is to address the following test failures caused by eventual consistency:

=== RUN   TestAccAWSEMRCluster_terminationProtected
--- FAIL: TestAccAWSEMRCluster_terminationProtected (31.22s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_1856153968257931906.
            status code: 400, request id: 254aeef3-fb51-11e7-9e9d-cd5480f30d78
=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- FAIL: TestAccAWSEMRCluster_visibleToAllUsers (53.67s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_4968740420325977163.
            status code: 400, request id: 2f9d9aeb-fb51-11e7-82e3-f1fe4c15039a
=== RUN   TestAccAWSEMRCluster_basic
--- FAIL: TestAccAWSEMRCluster_basic (24.83s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_500783995907791605.
            status code: 400, request id: 13c3efb4-fb51-11e7-8cb1-11ab57cf4bec
=== RUN   TestAccAWSEMRCluster_instance_group
--- FAIL: TestAccAWSEMRCluster_instance_group (39.47s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_9031346896681791865.
            status code: 400, request id: 13db4851-fb51-11e7-9e9d-cd5480f30d78
=== RUN   TestAccAWSEMRCluster_root_volume_size
--- FAIL: TestAccAWSEMRCluster_root_volume_size (28.04s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_6892146858256526138.
            status code: 400, request id: 39f0464d-fb51-11e7-acbd-b750accd83ef
=== RUN   TestAccAWSEMRInstanceGroup_basic
--- FAIL: TestAccAWSEMRInstanceGroup_basic (18.32s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_3527589066725277676.
            status code: 400, request id: 454ee353-fb51-11e7-b1e7-09a314c1a2f6
=== RUN   TestAccAWSEMRInstanceGroup_ebsBasic
--- FAIL: TestAccAWSEMRInstanceGroup_ebsBasic (21.88s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_2986140183728315022.
            status code: 400, request id: 5256006c-fb51-11e7-9e9d-cd5480f30d78
=== RUN   TestAccAWSEMRInstanceGroup_zero_count
--- FAIL: TestAccAWSEMRInstanceGroup_zero_count (21.22s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: 1 error(s) occurred:
        
        * aws_emr_cluster.tf-test-cluster: ValidationException: Invalid InstanceProfile: arn:aws:iam::*******:instance-profile/emr_profile_7691005927260896194.
            status code: 400, request id: 4aa4da72-fb51-11e7-af15-cd893ebf8cc9

Test results

=== RUN   TestAccAWSEMRCluster_security_config
--- PASS: TestAccAWSEMRCluster_security_config (516.97s)
=== RUN   TestAccAWSEMRCluster_basic
--- PASS: TestAccAWSEMRCluster_basic (537.61s)
=== RUN   TestAccAWSEMRCluster_terminationProtected
--- PASS: TestAccAWSEMRCluster_terminationProtected (635.60s)
=== RUN   TestAccAWSEMRCluster_s3Logging
--- PASS: TestAccAWSEMRCluster_s3Logging (639.43s)
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (639.95s)
=== RUN   TestAccAWSEMRCluster_instance_group
--- PASS: TestAccAWSEMRCluster_instance_group (679.98s)
=== RUN   TestAccAWSEMRInstanceGroup_ebsBasic
--- PASS: TestAccAWSEMRInstanceGroup_ebsBasic (744.62s)
=== RUN   TestAccAWSEMRInstanceGroup_basic
--- PASS: TestAccAWSEMRInstanceGroup_basic (745.12s)
=== RUN   TestAccAWSEMRInstanceGroup_zero_count
--- PASS: TestAccAWSEMRInstanceGroup_zero_count (770.33s)
=== RUN   TestAccAWSEMRCluster_root_volume_size
--- PASS: TestAccAWSEMRCluster_root_volume_size (949.05s)
=== RUN   TestAccAWSEMRCluster_tags
--- PASS: TestAccAWSEMRCluster_tags (976.47s)
=== RUN   TestAccAWSEMRCluster_visibleToAllUsers
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (1009.24s)

@radeksimko radeksimko added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. bug Addresses a defect in current functionality. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 17, 2018
@bflad bflad self-requested a review January 17, 2018 18:23
@bflad bflad added this to the v1.7.1 milestone Jan 17, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - passes TC and basic local testing :shipit:

@radeksimko radeksimko merged commit f54a22f into master Jan 17, 2018
@radeksimko radeksimko deleted the b-emr-retry-creation branch January 17, 2018 22:50
@bflad
Copy link
Contributor

bflad commented Jan 22, 2018

This has been released in terraform-provider-aws version 1.7.1. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants